changes to for bfcache#2615
Open
Vishala230531 wants to merge 5 commits into
Open
Conversation
nikrom17
requested changes
Apr 1, 2026
added 3 commits
April 1, 2026 10:00
Contributor
|
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
dist/button.js and dist/test/button.js are compiled output and shouldn't be committed to the source branch (per review comment on #2615). Reverted to match main; the actual source changes in src/types.js and src/zoid/*/component.jsx are untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements bfcache status for zoid component
Dependency PR'S
https://github.com/krakenjs/zoid/pull/479
https://github.com/krakenjs/belter/pull/130