Changes for toggling app switch for checkout#353
Conversation
* patchCCOWithAppSwitchEligibility * separate out PatchCcoWithAppSwitchEligibilityResponse * fix lint error * unit test and mock
* PayPalWebCheckout handleReturnURL * Steven PR feedback
|
I pushed this as a working draft of app switch for paypal web checkout. I want to separate out the PRs for readability and so reviews are not overwhelming and so unit tests don't have to be I will keep this PR as a draft and open other PRs in this order:
I may change order of #4 and #5 depending on what is the best path for unit testing. |
| self?.analyticsService?.sendEvent("paypal-web-payments:checkout:auth-challenge-presentation:failed") | ||
| } | ||
| }, | ||
| sessionDidComplete: { [weak self] url, error in |
There was a problem hiding this comment.
While I was testing vault web flow, I had a strange issue with infinite spinner upon return back to the demo app, completion was not being invoked.
I think it's because of the demo app not having a strong reference to the PayPalWebCheckoutClient
in the vaultViewModel in demo app. I faintly remember an inbound few years ago and this is the reason we removed [weak self] in sessionDidComplete block since we have no control over merchant integrations.
Removing weak self here solved the issue since the client with completion reference was not deallocated.
6d56dcb to
2482e50
Compare
Reason for changes
Summary of changes
TODO: unit tests
Checklist
Authors