[V3 Beta] Streamline Card Payments UI#384
Open
sshropshire wants to merge 24 commits into
Open
Conversation
…s to occur on the main thread.
sshropshire
force-pushed
the
v3-beta__streamline_ui
branch
from
April 27, 2026 22:28
118f9d0 to
c2d26c1
Compare
sshropshire
marked this pull request as ready for review
April 28, 2026 16:16
sshropshire
changed the title
MikeThorntonPayPal
self-requested a review
May 4, 2026 14:51
Comment on lines
+9
to
+11
| .font(.system(size: 20)) | ||
| .frame(maxWidth: .infinity, alignment: .leading) | ||
| .font(.headline) |
Collaborator
There was a problem hiding this comment.
Two .font() modifiers are applied to the same Text: .font(.system(size: 20)) and .font(.headline). The first one wins in SwiftUI, so .font(.headline) on line 11 is silently ignored. Remove one or the other.
| } | ||
| ScrollAnchor(id: "bottomAnchor") | ||
| } | ||
| .onChange(of: viewModel.stepCount) { _ in |
Collaborator
There was a problem hiding this comment.
onChange(of:) with trailing closure { _ in } is the deprecated iOS 14-style API. If the deployment target supports iOS 17+, use the newer onChange(of:) { oldValue, newValue in }
Collaborator
Author
There was a problem hiding this comment.
Should we upgrade the demo app to iOS 17? We probably should bump the min supported version for v3 of our SDK to give us more flexibility. I could improve this PR a good bit if we bump the version too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
environmentObjectandObservableObjectto clean up UI state management logic.After Refactor
screenshot-ui-post-streamline-refactor.mov
Current State on
mainscreenshot-ui-pre-streamline-refactor.mov
Checklist
Added a changelog entryAuthors