Add Latency Analytics Events for SSID Integration#415
Open
EdgarBarocio wants to merge 8 commits into
Open
Conversation
Add testing for new latency logic Move tests to a single shared file and delete old file to avoild duplicated symbols
This reverts commit be7966f.
EdgarBarocio
changed the title
sshropshire
reviewed
Jul 16, 2026
| paypalClient.vault(vaultRequest) { result in | ||
| paypalClient = client | ||
|
|
||
| print("📊 Using vault(createSetupToken:) — emits paypal-web-payments:api-request-latency") |
Collaborator
There was a problem hiding this comment.
Suggested change
| print("📊 Using vault(createSetupToken:) — emits paypal-web-payments:api-request-latency") |
Let's remove this print statement.
sshropshire
reviewed
Jul 16, 2026
|
|
||
| state.paypalVaultTokenResponse = .loading | ||
|
|
||
| try await withCheckedThrowingContinuation { (continuation: CheckedContinuation<Void, Error>) in |
Collaborator
There was a problem hiding this comment.
This method is deprecated, but also I'm not sure if it's needed since we aren't doing anything with the result.
sshropshire
reviewed
Jul 16, 2026
| } | ||
| case .success(let vaultResult): | ||
| self.state.paypalVaultTokenResponse = .loaded(vaultResult) | ||
| print("✅ Vault result: \(String(describing: vaultResult))") |
Collaborator
There was a problem hiding this comment.
Suggested change
| print("✅ Vault result: \(String(describing: vaultResult))") |
Please remove.
sshropshire
reviewed
Jul 16, 2026
| print("Canceled") | ||
| self.state.paypalVaultTokenResponse = .idle | ||
| } | ||
| print("Canceled") |
Collaborator
There was a problem hiding this comment.
Suggested change
| print("Canceled") |
Please remove.
sshropshire
approved these changes
Jul 20, 2026
…-ios into ebarocio/latency-analytics-ssid # Conflicts: # Demo/Demo.xcodeproj/project.pbxproj # Demo/Demo/PayPalVault/PayPalVaultViewModel/PayPalVaultViewModel.swift # Demo/Demo/PayPalWebPayments/PayPalWebPaymentsView/PayPalWebCreateOrderView.swift # Demo/Demo/PayPalWebPayments/PayPalWebPaymentsView/PayPalWebPaymentsView.swift # Demo/Demo/PayPalWebPayments/PayPalWebViewModel/PayPalWebViewModel.swift # Demo/Demo/SwiftUIComponents/CommonComponents/UserIdentityFactory.swift # Demo/Demo/Vault/VaultViewModel/VaultViewModel.swift # Demo/Demo/Vault/VaultViews/CreateSetupTokenView.swift # PayPal.xcodeproj/project.pbxproj # Sources/CorePayments/AnalyticsEventData.swift # Sources/CorePayments/Networking/AnalyticsService.swift # Sources/PayPalWebPayments/APIRequests/CreateShopperSessionAPI.swift # Sources/PayPalWebPayments/APIRequests/CreateShopperSessionResponse.swift # Sources/PayPalWebPayments/PayPalWebCheckoutClient.swift # UnitTests/TestShared/MockTrackingEventsAPI.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for changes
Introduce HTTP response timing and FPTI payload support for start_time/end_time, and fire api-request-latency and system-latency events from PayPalWebCheckoutClient createOrder/createSetupToken and checkout presentation paths.
Summary of changes
Checklist
Authors
Evidence
for paypal-web-payments:system-latency
for paypal-web-payments:api-request-latency
