useCreatePayLaterOneTimePaymentSession #697
Conversation
|
| return () => { | ||
| sessionRef.current?.destroy(); | ||
| sessionRef.current = null; | ||
| updateSession(null); |
There was a problem hiding this comment.
It is unclear to me if we need to update the session to null here.
In the case that the component is unmounted and this clean up runs, then we're updating state within an unmounted component and will trigger a React warning. I read in this blog post that the warning was removed in React 18, but react-paypal-js is on React 17. Found the actual React Working Group post on it here.
In the case that one of the dependencies has updated and the useEffect is going to rerun, I believe that the previous session will be replaced with the new session before the button re-renders.
There was a problem hiding this comment.
We discussed on slack here to remove this, but I wanted to keep the comment for posterity's sake
| // TODO what if sdk instance is not available? Error? | ||
| throw new Error("no sdk instance available"); |
There was a problem hiding this comment.
Good question about this. I think there are a few reasons that sdkInstance would be null, like if the hook is being used outside of the Provider for example. I wonder if discussing the error handling strategy overall is a good idea.
2 participants
No description provided.