feat(react-paypal-js-storybook): add v6 LPM stories#994
Open
Mathanjeevika wants to merge 3 commits into
Open
Conversation
…er core Adds the generic, registry-driven React wrapper for all 50 v6 Local Payment Methods, exposed via the ./sdk-v6/local-payment-methods subpath so the default @paypal/react-paypal-js export is unaffected. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Adds Storybook stories, a shared story factory, and a PayPal provider decorator for all 50 v6 Local Payment Methods, generated from the LPM_REGISTRY added in the react-paypal-js LPM wrapper. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: e27ab6b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shared/lpm/{code,storyFactory,utils}.ts), and a dedicated provider decorator (LPMPayPalProviderDecorator.tsx) for all 50 v6 SDK Local Payment Methods.generate:lpm-storiesscript that regenerates the 50 per-LPM story files from the LPM registry.skipPayPalProvideropt-out onwithPayPalProvider, anLPMgroup in the Storybook sidebar order, and the new decorator's barrel export.Context
This is PR 3 of 3 split out from #926 per review feedback requesting the original monolithic PR be broken up:
paypal-jsv6 LPM type declarationsreact-paypal-jscore LPM wrapperThis branch is stacked on #993's branch (
feature/lpm-react-wrapper-core), since the LPM stories importLPM_REGISTRY-driven exports from@paypal/react-paypal-js/sdk-v6/local-payment-methods. Because the head is on a fork, GitHub can only diff againstmain, so this PR's diff currently also includes #993's commit until #993 merges — please review only the last commit (feat(react-paypal-js-storybook): add v6 LPM stories) for now, or hold review until #992 and #993 land and this is rebased to show a clean diff.Test plan
npx tsc --noEmitpasses for the storybook v6 packagelint/test script exists for this Storybook package (not part of CI validation for this package)