Skip to content

Added language_requested fpti for analytics #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
surekhaw merged 26 commits into from
Feb 20, 2026
+49 −0
Merged

Added language_requested fpti for analytics #46

Show file tree
Hide file tree
Changes from 24 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
33088dc
support lang and locale msg params
surekhaw Jan 21, 2026
b368739
support lang and locale modal params
surekhaw Jan 21, 2026
2d334d5
update pipeline runner images
surekhaw Jan 22, 2026
c9ae6a2
fix cocoapods build and linting
surekhaw Jan 22, 2026
43fc385
support language and locale fields in demo app
surekhaw Jan 23, 2026
d18debe
fix linting errors
surekhaw Jan 23, 2026
1d3596a
fix modal reload on param change
surekhaw Jan 23, 2026
956daf8
fix test coverage
surekhaw Jan 23, 2026
2c03b65
Revert "fix test coverage"
surekhaw Jan 23, 2026
4298bbd
move modal reload
surekhaw Jan 24, 2026
8b7652d
add unit tests
surekhaw Jan 24, 2026
414ff65
fix linting
surekhaw Jan 24, 2026
d83d163
remove testShowModalDoesNotTriggerOnClick
surekhaw Jan 24, 2026
9780aac
refactor autocorrection
surekhaw Feb 2, 2026
a0d1d6c
comment to trigger workflow
surekhaw Feb 2, 2026
9dd1e5e
remove comment
surekhaw Feb 2, 2026
44e2fac
Revert "refactor autocorrection"This reverts commit 9780aac3e419b3c6c…
surekhaw Feb 2, 2026
a16f432
test refactor
surekhaw Feb 2, 2026
e573aa0
fix file
surekhaw Feb 3, 2026
ca2c979
fix linting error
surekhaw Feb 3, 2026
287c361
added language_requested fpti for analytics
anushreeshah2405 Feb 16, 2026
1363594
fixed linting, logger tests
anushreeshah2405 Feb 17, 2026
ceec884
Merge remote-tracking branch 'origin/develop' into feature/lang_reque…
anushreeshah2405 Feb 17, 2026
68b0625
remove tracking from modal
anushreeshah2405 Feb 18, 2026
a6c22b9
added tests
anushreeshah2405 Feb 20, 2026
a4336f7
fixed test output typo
anushreeshah2405 Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Sources/PayPalMessages/Analytics/AnalyticsLogger.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ class AnalyticsLogger: Encodable {
case pageType = "page_type"
case buyerCountryCode = "buyer_country_code"
case channel = "presentment_channel"
case languageRequested = "language_requested"
// Message Only
case styleLogoType = "style_logo_type"
case styleColor = "style_color"
Expand Down Expand Up @@ -78,6 +79,10 @@ class AnalyticsLogger: Encodable {
try container.encodeIfPresent(message.logoType.rawValue, forKey: .styleLogoType)
try container.encodeIfPresent(message.color.rawValue, forKey: .styleColor)
try container.encodeIfPresent(message.textAlign.rawValue, forKey: .styleTextAlign)
let languageRequested = message.locale?.replacingOccurrences(of: "_", with: "-")
?? message.language
?? "undefined"
try container.encodeIfPresent(languageRequested, forKey: .languageRequested)

case .modal(let weakModal):
guard let modal = weakModal.value else { return }
Expand Down
5 changes: 5 additions & 0 deletions Tests/PayPalMessagesTests/PayPalMessageLoggerTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ final class PayPalMessageLoggerTests: XCTestCase {
"style_logo_type": "inline",
"style_color": "black",
"style_text_align": "left",
"language_requested": "undefined",
"component_events": [
[
"event_type": "message_rendered",
Expand Down Expand Up @@ -246,6 +247,7 @@ final class PayPalMessageLoggerTests: XCTestCase {
"style_logo_type": "inline",
"style_color": "black",
"style_text_align": "left",
"language_requested": "undefined",
"component_events": [
[
"event_type": "message_rendered",
Expand Down Expand Up @@ -314,6 +316,7 @@ final class PayPalMessageLoggerTests: XCTestCase {
"style_logo_type": "inline",
"style_color": "black",
"style_text_align": "left",
"language_requested": "undefined",
"component_events": [
[
"event_type": "message_rendered",
Expand Down Expand Up @@ -371,6 +374,7 @@ final class PayPalMessageLoggerTests: XCTestCase {
"style_logo_type": "inline",
"style_color": "black",
"style_text_align": "left",
"language_requested": "undefined",
"component_events": [
[
"event_type": "message_clicked",
Expand Down Expand Up @@ -437,6 +441,7 @@ final class PayPalMessageLoggerTests: XCTestCase {
"style_logo_type": "inline",
"style_color": "black",
"style_text_align": "left",
"language_requested": "undefined",
"component_events": [
[
"event_type": "message_rendered",
Expand Down