Skip to content

PP6-122 & PP6-124 #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kotivuori merged 4 commits into from
Sep 15, 2025
Merged

PP6-122 & PP6-124 #49

kotivuori merged 4 commits into from
Sep 15, 2025

Conversation

@OttiaDevsPT
Copy link
Collaborator

@OttiaDevsPT OttiaDevsPT commented Aug 5, 2025 •
edited
Loading

Related tickets & documents

JS SDK: Update Item unitPrice validation

Fix tests to use model classes

Description

  • Removed @min(0) from unitPrice to allow negative values as per Paytrail docs.
  • Added custom decorator to validate unitPrice
    Prevents negative values if:
    • usePricesWithoutVat = true, or
    • Item is part of Shop-in-Shop.
  • Handled Shop-in-Shop limitation in its model class.
  • Added tests to verify all cases:
  • updated testcases from plain object to proper SDK model classes

@OttiaDevsPT
PP6-122 Update Item Model
21d06d6 
- supports negative item unitPrice
- created Testcase for negative item unitPrice
@OttiaDevsPT
PP6-124
5c38b72 
- Updated from plain objects to updated SDK model classes
@OttiaDevsPT OttiaDevsPT requested a review from kotivuori August 5, 2025 10:30
OttiaDevsPT and others added 2 commits August 22, 2025 10:43
@OttiaDevsPT
PP6-124
ae0381b 
- moved commission logic back to the ShopInShopItem model
- extracted custom validators and decorators into their own files
@OttiaDevsPT
PP6-122: Move unitPrice validation to items in CreatePaymentRequest
3268cac
@kotivuori kotivuori merged commit 2c36b72 into main Sep 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kotivuori kotivuori kotivuori approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@OttiaDevsPT @kotivuori