Skip to content

createAddCardFormRequest doesn't calculate signature #55 - #60

Merged
kotivuori merged 5 commits into
mainfrom
feature/create-add-card-form-signature
Feb 27, 2026
Merged

createAddCardFormRequest doesn't calculate signature #55#60
kotivuori merged 5 commits into
mainfrom
feature/create-add-card-form-signature

Conversation

@OttiaDevsPT

Copy link
Copy Markdown
Contributor

What's Changed

Breaking Change: Refactored createAddCardFormRequest to internalize signature calculation and authentication parameters. This aligns the method with the rest of the SDK patterns and simplifies usage for developers. The AddCardFormRequest model no longer requires checkoutAccount, checkoutMethod, checkoutNonce, checkoutTimestamp, checkoutAlgorithm, or signature to be populated manually.

Features

  • Internalized signature calculation for createAddCardFormRequest (matches createPayment pattern).
  • Implemented Form Post style authentication (Body Auth) for add-card requests.

Refactoring

  • Removed manual authentication fields from AddCardFormRequest model.
  • Automatically injects merchant credentials and generates HMAC signature within the SDK.

Testing

  • Added unit tests to verify signature generation and payload structure for card form requests.

@OttiaDevsPT

OttiaDevsPT commented Jan 29, 2026

Copy link
Copy Markdown
Contributor Author

@kotivuori we fixed the Lint issues on the code we created but there are some fails still in other sections
image

Do you think we should try to fix those separately or?

@kotivuori
kotivuori merged commit 0d97430 into main Feb 27, 2026
2 checks passed
@kotivuori
kotivuori deleted the feature/create-add-card-form-signature branch February 27, 2026 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants