Add copy restarts flag to ROMS driver #630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't added any tests, but I have run 5 cycles of the upwelling roms test case and it works as expected: a new restart file is created each time and used correctly in subsequent runs: and the checksums match those in the |
|
This is a diff showing the restart files being picked up in the manifests $ git diff HEAD^ manifests/restart.yaml
diff --git a/manifests/restart.yaml b/manifests/restart.yaml
index d4700cf..b205b05 100644
--- a/manifests/restart.yaml
+++ b/manifests/restart.yaml
@@ -3,7 +3,7 @@ version: 1.0
---
work/roms_rst.nc:
copy: true
- fullpath: /scratch/xxXX/xxxXXX/roms/archive/roms-upwelling-release-upwelling+testcase-f4a04601/restart002/roms_rst.nc
+ fullpath: /scratch/xxXX/xxxXXX/roms/archive/roms-upwelling-release-upwelling+testcase-f4a04601/restart003/roms_rst.nc
hashes:
- binhash: 7c0dcd63936ddac5d02ea53adcdd1580
- md5: 5db062f00903347876457375c2670754
+ binhash: edbcaa6317cb8d3862e98e189787d727
+ md5: 910af540519ad3ba3078355e5d0a7fd0Note that |
helenmacdonald
approved these changes
Sep 18, 2025
phellipecouto
approved these changes
Sep 19, 2025
There was a problem hiding this comment.
@aidanheerdegen I'm happy with that solution and can see this working well, based on the results you obtained with the upwelling test run, for hindcast and forecast simulations. Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #629
ROMS reads from and writes to the same restart file, so added a copy restarts flag as the simplest and easiest solution.