fix: deduplicate null_as_empty_vec and normalize user_order channel name#33
Merged
fix: deduplicate null_as_empty_vec and normalize user_order channel name#33
Conversation
Move the duplicated null_as_empty_vec serde helper from market.rs and order.rs into a shared pub(crate) module in common.rs. Normalize the "user_order" (singular) message type to "user_orders" in session.rs so StreamUpdate.channel always uses the canonical channel name, preventing mismatches in reconnect logic and downstream filtering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses two issues from the PR #31 review:
Deduplicate
null_as_empty_vec: The serde helper was duplicated byte-for-byte inmarket.rsandorder.rs. Moved to a sharedpub(crate)module incommon.rsand replaced both copies withuse super::common::null_as_empty_vec.Normalize
"user_order"channel name: The Kalshi API sends"user_order"(singular) as the message type, but the channel is subscribed as"user_orders"(plural). Without normalization,StreamUpdate.channelwould be"user_order"for those messages, which wouldn't match the canonicalChannel::UserOrdersname in reconnect logic or downstream filtering. Added normalization insession.rsat the update handling point.Test plan
cargo checkpassescargo clippy -- -D warningscleancargo test— all 196 tests passcargo fmt --checkclean