Merged
Conversation
Convert `.unwrap()` calls on oneshot channel receives to use `.map_err()` with proper error propagation. This prevents panics when the internal plant connection closes unexpectedly, instead returning a recoverable "Connection closed" error to callers.
- Update version to 0.7.1 in Cargo.toml and README.md - Add comprehensive CHANGELOG entry for 0.7.1 release - Improve tests for rithmic_to_unix_nanos_precise with realistic timestamps
Use `if let Some(err)` pattern instead of `is_none()` check followed by `unwrap()` to satisfy clippy's unnecessary_unwrap lint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release 0.7.1 with new utility types, helper methods, and bug fixes.
Added
util) withInstrumentInfo,OrderStatus, and timestamp conversion helpersRithmicResponsehelper methods:is_error(),is_connection_issue(),is_market_data()serdefeature flag forRithmicEnvserializationbracket_order.rsexampleFixed
.unwrap()panics with proper error handling in all plant handlesChanged
rithmic_to_unix_nanos_precisewith realistic timestampsTest plan
cargo checkpassescargo testpassescargo fmt- no changescargo clippy- no warnings