Skip to content

Conversation

@soundarapandian
Copy link
Contributor

Normally links in standard navbar will toggle in mobile devices. So I have placed two different language switch to ensure it displayed correctly in large screen and mobile devices.

Its not the final solution. I have fixed only the design. Attaching few screenshots

desktop-and-tablet

mobile

on-toggle

@soundarapandian
Copy link
Contributor Author

@pcav Its good to merge now.

@pcav
Copy link
Owner

pcav commented Jan 7, 2014

Hi Soundar,
I do not have an infrastructure for testing, so I'm cautious before merging. From the images above, the bahaviour is not the desired one (in fact, the lang switch should not be very prominent, as it should be used only in corner cases, like having a browser in one lang, and wishing to read the site in another one).
Could you please set up a sample site with your modifications, for deeper inspection, or send some updated screeshots?
Thanks.

@soundarapandian
Copy link
Contributor Author

Actually I have fixed what is being discussed here.

#86 (comment). But your comments says lang switch should not be very prominent

Can you please point me the actual problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants