Skip to content

Update ExtractStrings.js#1

Open
zahidhussain998 wants to merge 1 commit into
pcenov:release-v0.14.xfrom
zahidhussain998:patch-1
Open

Update ExtractStrings.js#1
zahidhussain998 wants to merge 1 commit into
pcenov:release-v0.14.xfrom
zahidhussain998:patch-1

Conversation

@zahidhussain998

Copy link
Copy Markdown

change the var into let and `Translator object called with undefined messages argument in ${module.resource} it was in the if else statement instead i changed ternary operator because it was look like awkward

Summary

Reviewer guidance

References


Contributor Checklist

PR process:

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Testing:

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

Reviewer Checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

change the var into let and `Translator object called with undefined messages argument in ${module.resource}
it was in the if else statement instead i changed ternary operator because it was look like awkward
pcenov pushed a commit that referenced this pull request Feb 23, 2024
pcenov pushed a commit that referenced this pull request Feb 23, 2024
pcenov pushed a commit that referenced this pull request Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant