Multiple outputs #277
Multiple outputs #277
Conversation
| class { '::filebeat::repo': } | ||
| Class['filebeat::repo'] -> Class['filebeat::install::linux'] | ||
| include elastic_stack::repo | ||
| Class['elastic_stack::repo'] -> Class['filebeat::install::linux'] |
There was a problem hiding this comment.
I love the idea of using the upstream elastic repo as suggested in #189, but we customize a few things in the setup. I think it's reasonable to ask users that need those customizations to set manage_repo to false and manage it themselves, but we should probably remove references to the parameters too (README, params.pp, init.pp).
| } | ||
| } | ||
| } | ||
| define filebeat::service::add { |
There was a problem hiding this comment.
Can we split the defined type in to its own file.
We might want to think about titling this one a little different too since we're not creating a new "add". I don't have another idea yet though.
|
Thanks @mdklapwijk! This will help a lot moving towards some form of support on #48 too. It sounds like there are a lot of changes in here in addition to supporting multiple outputs, including deprecating support for Filebeat 6 (probably time to do that anyway), switches to the I'd like to add some unit tests to the systemd logic so we can confidently make changes in the future (I need to move them from Travis to GitHub actions so they run here too). |
|
Hi Phil, I was planning on starting a stripped version, dropping FB6, Windows support etc. So I could implement filebeat::output, just like filebeat::input. As stated, this was my first attempt at this and it was done in such a manner it would not interfere with the already existent logic, hence the big foreach-loop over the outputs-hash in config.pp. If you are interested I would create a new branch for this later this week, as I already (partly) done the filebeat::output, but it broke backward compat. a bit... Regards, Marcel |
2 participants
First try at allowing filebeat having multiple outputs:
Note: only tested on Debian 10.