This PR fixes #354 #355
Merged
This PR fixes #354 #355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR makes many changes that are outside of the scope of the issue mentioned above. They are improvements, but if you disagree, please feel free to cherry-pick. * [Change] Switched to version 11 of the apt module, as it is the first to support the new key requirements * [Change] Changed the apt::source resource in repo.pp to install the key in such a way as to avoid the deprecation notice from apt * [Change] Updated PDK to v3.4.0 because it is the most recent non-closed-source version of PDK * [Addition] Added missing documentation for parameters * [Change] Changed the class/parameter documentation to match modern code standards * [Change] Removed anchor resources and replaced them with contains because anchors are deprecated and have been for years * [Change] Updated tests to match the anchor to contain changes * [Change] A lot of small code changes to satisfy pdk validate * [Change] Increased the max version for the archive module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes many changes that are outside of the scope of the issue mentioned above. They are improvements, but if you disagree, please feel free to cherry-pick.