runner: don't fail if shellcheck is not installed #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulRbr
force-pushed
the
dont-fail-missing-deps
branch
from
1ce0219 to
c52214a
Compare
|
Hi @pclalv , WDYT of this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is quite common to run
prontoin a CI environment (continuous integration) to make sure that style / linting options on a repo are enforced at the PR level.Thus it's the responsibility of the CI to have all dependencies installed to run all configured pronto runners on a dedicated repo.
However sometimes there are some tools not used by all the contributors of a specific repository (e.g. some developers make changes only on frontend related code while some others only make changes on backend code for instance).
In this context, the goal of this PR is to remove the hard dependency on the
shellcheckbinary. With this change, a warning message will be given to the user but it won't raise an exception (and by consequence stop any other pronto runners).