Allow a preceding middleware to opt out of the check#11
Open
daniel5gh wants to merge 2 commits intopcraston:masterfrom
Open
Allow a preceding middleware to opt out of the check#11daniel5gh wants to merge 2 commits intopcraston:masterfrom
daniel5gh wants to merge 2 commits intopcraston:masterfrom
Conversation
This works by having a middleware add `_allow_concurrent_logins` to the request object with any value that evaluates to True.
Owner
|
Hi! Thanks for the contribution. Been really busy recently so haven't had a chance to review and release new version but will do soon! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I had a use case where I want certain requests to opt out from the concurrent login check. I implemented that by having a middleware add
_allow_concurrent_loginsto the request object with any value that evaluates to True. The preventconcurrentlogins middleware checks for this flag and exits early when it is set.Figured I'd make a PR in case you are interested in including this.
Thanks,
Daniel