Skip to content

Fix even logo sizes, add Home to menu, and full PDI team in People#5

Merged
benoitmartin88 merged 17 commits into
mainfrom
fix_logo_menu_people
Dec 16, 2025
Merged

Fix even logo sizes, add Home to menu, and full PDI team in People#5
benoitmartin88 merged 17 commits into
mainfrom
fix_logo_menu_people

Conversation

@JAuriac

@JAuriac JAuriac commented Dec 12, 2025

Copy link
Copy Markdown
Contributor

Fix even logo sizes, add Home to menu, and full PDI team in People

Yushan-Wang
Yushan-Wang previously approved these changes Dec 12, 2025

@benoitmartin88 benoitmartin88 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some changes are needed.

Comment thread site/hugo.yaml Outdated
Comment thread site/hugo.yaml Outdated
Comment thread site/hugo.yaml Outdated
Comment thread site/hugo.yaml Outdated
Comment thread site/hugo.yaml Outdated
…window (with the exception of pdi.dev/main), and add links to images
Comment thread site/hugo.yaml
Comment thread site/layouts/_default/_markup/render-link.html
@benoitmartin88

Copy link
Copy Markdown
Member

@JAuriac It looks like there are a lot manual changing of styles in this PR (eg: style="border-radius: 0rem; padding: 0.9rem !important;"). Would it not be better to add a custom style.css file where the changes you make to the specific css classes are made ?

@JAuriac

JAuriac commented Dec 15, 2025

Copy link
Copy Markdown
Contributor Author

@JAuriac It looks like there are a lot manual changing of styles in this PR (eg: style="border-radius: 0rem; padding: 0.9rem !important;"). Would it not be better to add a custom style.css file where the changes you make to the specific css classes are made ?

Indeed, there are now too many exceptions.

Comment thread site/layouts/partials/head.html Outdated
@benoitmartin88
benoitmartin88 merged commit b90d148 into main Dec 16, 2025
1 check passed
@benoitmartin88
benoitmartin88 deleted the fix_logo_menu_people branch January 23, 2026 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants