Add Catalyst Plugin.#496
Open
francois-kitware wants to merge 72 commits into
Open
Conversation
Open
jbigot
reviewed
Dec 11, 2024
jbigot
left a comment
Member
There was a problem hiding this comment.
Can you also add Kitware to the copyright at the top of the root CMakeLists.txt you contributed to
Member
|
Thank you so much for the contribution @francois-kitware ! From our point of view, it's basically good to go as-is, if you maintain the plugin separately in a submodule. We just need to add a Changelog entry, and some other minor elements related to our "checkboxes". Would you also be interested in the review of the plugin code? In this case, this should be done on your gitlab since from github we only have a submodule reference. |
francois-kitware
force-pushed
the
catalyst-plugin
branch
from
January 29, 2025 10:43
d9b3078 to
98655ea
Compare
Yushan-Wang
requested review from
Yushan-Wang and
benoitmartin88
as code owners
October 17, 2025 10:36
francois-kitware
commented
Nov 7, 2025
francois-kitware
commented
Nov 7, 2025
francois-kitware
commented
Nov 7, 2025
francois-kitware
commented
Nov 7, 2025
Yushan-Wang
reviewed
Nov 19, 2025
jmorice91
force-pushed
the
catalyst-plugin
branch
from
November 24, 2025 15:22
e8cfd88 to
8d46e43
Compare
benoitmartin88
requested changes
Dec 3, 2025
benoitmartin88
left a comment
Member
There was a problem hiding this comment.
Thank you for this contribution.
I think a little refactoring is needed.
jmorice91
requested review from
JAuriac,
Yushan-Wang,
benoitmartin88 and
jmorice91
and removed request for
jmorice91
December 5, 2025 09:59
Yushan-Wang
previously approved these changes
Dec 5, 2025
Yushan-Wang
reviewed
Dec 12, 2025
jbigot
marked this pull request as draft
February 10, 2026 09:11
jmorice91
force-pushed
the
catalyst-plugin
branch
from
February 24, 2026 10:15
a405fad to
5c0fc8a
Compare
jbigot
force-pushed
the
main
branch
7 times, most recently
from
April 24, 2026 09:13
41fed24 to
b9ebda1
Compare
jmorice91
force-pushed
the
catalyst-plugin
branch
from
July 20, 2026 14:40
69c5713 to
54f1ee7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the catalyst plugin developed by Kitware as an official PDI plugin.
The plugin code have been copied in the branch and the catalyst library dependency is added as a submodule for easy update in the future.
When built with
BUILD_TESTINGCMake variable, the pdi-catalyst-plugin tests should pass:Looks like lots of boxes below are not checked. I'll update everything after PDI's team code review.
François
List of things to check before making a PR
Before merging your code, please check the following:
.clang-format;Fix #issuekeyword to autoclose the issue when merged.