Skip to content

Fix for PR 711 of issue 500, and documentation#714

Open
JAuriac wants to merge 3 commits into
mainfrom
500_CheckPluginAvailabilityFix
Open

Fix for PR 711 of issue 500, and documentation#714
JAuriac wants to merge 3 commits into
mainfrom
500_CheckPluginAvailabilityFix

Conversation

@JAuriac

@JAuriac JAuriac commented Jun 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fix for PR #711

List of things to check before making a PR

Before merging your code, please check the following:

  • you have added a line describing your changes to the Changelog;
  • you have added unit tests for any new or improved feature;
  • in case you updated dependencies, you have checked pdi/docs/CheckList.md;
  • in case of a change in pdi.h, this same change must be reflected in mock_pdi/pdi.h;
  • you have checked your code format:
    • you have checked that you respect all conventions specified in CONTRIBUTING.md;
    • you have checked that the indentation and formatting conforms to the .clang-format;
    • you have documented with doxygen any new or changed function / class;
  • you have correctly updated the copyright headers:
    • your institution is in the copyright header of every file you (substantially) modified;
    • you have checked that the end-year of the copyright there is the current one;
  • you have updated the AUTHORS file:
    • you have added yourself to the AUTHORS file;
    • if this is a new contribution, you have added it to the AUTHORS file;
  • you have added everything to the user documentation:
    • any new CMake configuration option;
    • any change in the yaml config;
    • any change to the public or plugin API;
    • any other new or changed user-facing feature;
    • any change to the dependencies;
  • you have correctly linked your MR to one or more issues:
    • your MR solves an identified issue;
    • your commit contain the Fix #issue keyword to autoclose the issue when merged.

Yushan-Wang
Yushan-Wang reviewed Jun 24, 2026
View reviewed changes
Comment thread CHANGELOG.md Outdated
@JAuriac
JAuriac force-pushed the 500_CheckPluginAvailabilityFix branch from b65852f to a4802a9 Compare June 25, 2026 09:06
@JAuriac
JAuriac requested a review from jmorice91 June 25, 2026 09:08
@JAuriac
JAuriac marked this pull request as ready for review June 29, 2026 07:55
jmorice91
jmorice91 reviewed Jun 30, 2026
View reviewed changes
Comment thread pdi/docs/Source_installation.md Outdated
jmorice91
jmorice91 reviewed Jun 30, 2026
View reviewed changes
Comment thread CMakeLists.txt Outdated
Yushan-Wang
Yushan-Wang requested changes Jul 6, 2026
View reviewed changes
Comment thread CHANGELOG.md Outdated
Comment thread pdi/docs/Source_installation.md
Comment thread CHANGELOG.md Outdated
@benoitmartin88

benoitmartin88 commented Jul 16, 2026

Copy link
Copy Markdown
Member

Does this PR fix an identified issue ?

@JAuriac JAuriac changed the title Fix for PR 500, and documentation Fix for PR 711 of issue 500, and documentation Jul 16, 2026
@JAuriac

JAuriac commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

Does this PR fix an identified issue ?

This PR (#714) follows the merge of a PR (#711) that was still at draft state at the time it was merged. It is a follow-up on the same issue (#500)

@Yushan-Wang Yushan-Wang linked an issue Jul 16, 2026 that may be closed by this pull request
Check for parrallel plugin availability trough multiple locations #500
Open
Yushan-Wang
Yushan-Wang previously approved these changes Jul 16, 2026
View reviewed changes
Comment thread CHANGELOG.md Outdated
@Yushan-Wang

Yushan-Wang commented Jul 16, 2026

Copy link
Copy Markdown
Member

Please rebase and check all the checkboxes. Then it's ready to be merged.

jbigot
jbigot reviewed Jul 18, 2026
View reviewed changes
Comment thread CHANGELOG.md Outdated
@JAuriac
JAuriac force-pushed the 500_CheckPluginAvailabilityFix branch from d0f5501 to 66f4487 Compare July 21, 2026 12:56
Yushan-Wang
Yushan-Wang previously approved these changes Jul 22, 2026
View reviewed changes
jbigot
jbigot reviewed Jul 24, 2026
View reviewed changes
Comment thread pdi/docs/Source_installation.md Outdated
jbigot
jbigot reviewed Jul 24, 2026
View reviewed changes
Comment thread pdi/docs/Source_installation.md Outdated
jbigot
jbigot reviewed Jul 24, 2026
View reviewed changes
Comment thread pdi/docs/Source_installation.md Outdated
Yushan-Wang
Yushan-Wang previously approved these changes Jul 24, 2026
View reviewed changes
jbigot
jbigot reviewed Jul 24, 2026
View reviewed changes
Comment thread pdi/docs/Source_installation.md Outdated
jbigot
jbigot reviewed Jul 24, 2026
View reviewed changes
Comment thread CMakeLists.txt Outdated
)
endif()
elseif(NOT "EMBEDDED" STREQUAL "${USE_HDF5}")
elseif("SYSTEM" STREQUAL "${USE_HDF5}")

@jbigot jbigot Jul 24, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the change?

jbigot
jbigot reviewed Jul 24, 2026
View reviewed changes
Comment thread CMakeLists.txt Outdated
)
endif()
elseif(NOT "EMBEDDED" STREQUAL "${USE_NetCDF}")
elseif("SYSTEM" STREQUAL "${USE_NetCDF}")

@jbigot jbigot Jul 24, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the change?

@Yushan-Wang Yushan-Wang Jul 24, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To exclude the case of 'AUTO' if I remember correctly

@jbigot jbigot Jul 25, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For AUTO, I think the message also makes sense, hence the original wording, no?

@jbigot

jbigot commented Jul 25, 2026

Copy link
Copy Markdown
Member

Is this for #711 or #697 ?

JAuriac and others added 2 commits July 25, 2026 13:06
@JAuriac @jbigot
Add feedback 30-06-2026
a4f07f5
@jbigot
Minor improvements:
26b2ba6 
* reference existing doc
* give messages for AUTO
* remove deleted options from doc
@jbigot
jbigot force-pushed the 500_CheckPluginAvailabilityFix branch from aebdf55 to 26b2ba6 Compare July 25, 2026 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbigot jbigot jbigot left review comments
@Yushan-Wang Yushan-Wang Yushan-Wang left review comments
@jmorice91 jmorice91 jmorice91 left review comments
@benoitmartin88 benoitmartin88 Awaiting requested review from benoitmartin88

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Check for parrallel plugin availability trough multiple locations

5 participants

@JAuriac @benoitmartin88 @Yushan-Wang @jbigot @jmorice91