Skip to content

feat: respect .python-version file#3367

Merged
frostming merged 3 commits intomainfrom
feat/version-file
Jan 2, 2025
Merged

feat: respect .python-version file#3367
frostming merged 3 commits intomainfrom
feat/version-file

Conversation

@frostming
Copy link
Collaborator

Signed-off-by: Frost Ming me@frostming.com

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Signed-off-by: Frost Ming <me@frostming.com>
@frostming frostming linked an issue Jan 2, 2025 that may be closed by this pull request
1 task
Signed-off-by: Frost Ming <me@frostming.com>
Signed-off-by: Frost Ming <me@frostming.com>
@codecov
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.

Project coverage is 85.21%. Comparing base (1d44e71) to head (0229cd4).
Report is 31 commits behind head on main.

Files with missing lines Patch % Lines
src/pdm/project/core.py 81.81% 1 Missing and 1 partial ⚠️
src/pdm/cli/commands/use.py 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3367      +/-   ##
==========================================
+ Coverage   84.71%   85.21%   +0.49%     
==========================================
  Files         112      112              
  Lines       11467    11482      +15     
  Branches     2510     2515       +5     
==========================================
+ Hits         9714     9784      +70     
+ Misses       1218     1171      -47     
+ Partials      535      527       -8     
Flag Coverage Δ
unittests 84.52% <82.35%> (+0.75%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@frostming frostming merged commit 6c52c4e into main Jan 2, 2025
18 of 19 checks passed
@frostming frostming deleted the feat/version-file branch January 2, 2025 02:10
carstencodes added a commit to carstencodes/pdm-bump that referenced this pull request Jan 22, 2025
As of pdm-project/pdm#3367
the .python-version file is taken into account

Hence this file is now more important and
will define the matrix to run.
carstencodes added a commit to carstencodes/pdm-bump that referenced this pull request Jan 22, 2025
As of pdm-project/pdm#3367
the .python-version file is taken into account

Hence this file is now more important and
will define the matrix to run.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Where is python?

1 participant

Comments