models: port to hishel 1.0#3700
Merged
frostming merged 3 commits intopdm-project:mainfrom Dec 23, 2025
Merged
Conversation
3ae5d0e to
a3d89d9
Compare
fd84e98 to
4bea968
Compare
Signed-off-by: Ivan Shapovalov <intelfx@intelfx.name>
Signed-off-by: Ivan Shapovalov <intelfx@intelfx.name>
4bea968 to
56b87fe
Compare
frostming
reviewed
Dec 15, 2025
Collaborator
frostming
left a comment
There was a problem hiding this comment.
This change is generally good, with some minor tweaks
Signed-off-by: Frost Ming <me@frostming.com>
frostming
approved these changes
Dec 23, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3700 +/- ##
==========================================
- Coverage 85.97% 85.93% -0.04%
==========================================
Files 119 118 -1
Lines 12402 12367 -35
Branches 2057 2060 +3
==========================================
- Hits 10662 10628 -34
Misses 1166 1166
+ Partials 574 573 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I think this PR might have broken PyPy; in scientific-python/cookie I'm now getting (on PyPy only): |
Collaborator
|
It's being tracked by #3706 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
news/describing what is new.Describe what you have changed in this PR.
SyncSqliteStorageFixes: #3657