Skip to content

models: port to hishel 1.0#3700

Merged
frostming merged 3 commits intopdm-project:mainfrom
intelfx:work/hishel-1.0
Dec 23, 2025
Merged

models: port to hishel 1.0#3700
frostming merged 3 commits intopdm-project:mainfrom
intelfx:work/hishel-1.0

Conversation

@intelfx
Copy link
Contributor

@intelfx intelfx commented Dec 14, 2025

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

  • Port to hishel 1.0.0
  • Drop custom serializers and related tests
  • Throw together a very dirty thread-safe wrapper around SyncSqliteStorage

Fixes: #3657

@intelfx intelfx marked this pull request as draft December 14, 2025 12:11
@intelfx intelfx force-pushed the work/hishel-1.0 branch 3 times, most recently from fd84e98 to 4bea968 Compare December 14, 2025 18:33
@intelfx intelfx marked this pull request as ready for review December 14, 2025 18:34
Signed-off-by: Ivan Shapovalov <intelfx@intelfx.name>
Signed-off-by: Ivan Shapovalov <intelfx@intelfx.name>
Copy link
Collaborator

@frostming frostming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is generally good, with some minor tweaks

Signed-off-by: Frost Ming <me@frostming.com>
@codecov
Copy link

codecov bot commented Dec 23, 2025

Codecov Report

❌ Patch coverage is 97.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 85.93%. Comparing base (21d154c) to head (08ad7ac).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/pdm/models/session.py 97.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3700      +/-   ##
==========================================
- Coverage   85.97%   85.93%   -0.04%     
==========================================
  Files         119      118       -1     
  Lines       12402    12367      -35     
  Branches     2057     2060       +3     
==========================================
- Hits        10662    10628      -34     
  Misses       1166     1166              
+ Partials      574      573       -1     
Flag Coverage Δ
unittests 85.79% <97.50%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@frostming frostming merged commit d8027fe into pdm-project:main Dec 23, 2025
42 of 45 checks passed
@henryiii
Copy link

henryiii commented Dec 30, 2025

I think this PR might have broken PyPy; in scientific-python/cookie I'm now getting (on PyPy only):

nox > Running session native(pdm, vcs, sphinx)
nox > Creating virtual environment (uv) using python in .nox/native-pdm-vcs-sphinx
nox > uv pip install cookiecutter pdm
nox > cd .nox/native-pdm-vcs-sphinx/tmp
nox > cookiecutter --no-input /home/runner/work/cookie/cookie --config-file=input.yml
nox > git -C cookie-pdm init -q
nox > git -C cookie-pdm add .
nox > git -C cookie-pdm -c user.name=Bot -c user.email=bot@scikit-hep.org commit -qm 'feat: initial version'
nox > git -C cookie-pdm tag v0.2.3
nox > cd cookie-pdm
nox > pdm install
WARNING: Lockfile does not exist
Updating the lock file...
INFO: Inside an active virtualenv 
/home/runner/work/cookie/cookie/.nox/native-pdm-vcs-sphinx, reusing it.
Set env var PDM_IGNORE_ACTIVE_VENV to ignore it.
25l⠋ 0:00:00 Resolving dependencies  
⠋ 0:00:00 Resolve for environment (>=3.10) None
⠸ 0:00:00 Resolve for environment (>=3.10) None
⠦ 0:00:00 Resolve for environment (>=3.10) None
⠏ 0:00:00 Resolve for environment (>=3.10) None
⠋ 0:00:00 Resolve for environment (>=3.10) None
25hSee /home/runner/.local/state/pdm/log/pdm-lock-xnr8b_i5.log for detailed debug 
log.
[OperationalError]: cannot commit transaction - SQL statements in progress
WARNING: Add '-v' to see the detailed traceback
nox > Command pdm install failed with exit code 1
nox > Session native(pdm, vcs, sphinx) failed.
Error: Process completed with exit code 1.

@frostming
Copy link
Collaborator

It's being tracked by #3706

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

hishel 1.0.0 breaks PDM usage

3 participants

Comments