fix: handle stale metadata, narrator mismatch, and re-tag/re-merge support#21
Open
pdugan20 wants to merge 1 commit into
Open
fix: handle stale metadata, narrator mismatch, and re-tag/re-merge support#21pdugan20 wants to merge 1 commit into
pdugan20 wants to merge 1 commit into
Conversation
The Chrome extension writes `narrators` (plural, string[]) to metadata.json but the CLI read `narrator` (singular, string), so the narrator field was always undefined. Also fix several usability issues that prevented updating metadata: - CLI option overrides (--title, --author, etc.) were silently ignored when metadata.json existed - Interactive menu hid already-tagged/merged books, blocking re-runs - Merge command failed on existing M4B with no way to overwrite Changes: - Read `narrators[]` array from metadata.json in both MetadataService and MergeService, with fallback to legacy `narrator` field - Apply CLI option overrides on top of metadata.json values - Show all books in interactive tag/merge menus with status indicators - Add --force flag to merge command to overwrite existing M4B files - Auto-force when re-merging via interactive menu
pdugan20
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
narrators[]) and CLI (narrator) - narrator was always undefined--title,--author,--narrator) now properly override metadata.json values--forceflag to merge command for overwriting existing M4B filesTest plan
npm run devand verify all books appear in tag/merge menus with status indicators