feat: update GasLimitStorageGrowthRatio to 366 #382
Conversation
|
The preview deployment for peaqnetwork/peaq-network-node:ci/012453_add-auto-upgrade-on-preview-environment-iswg08ckww0c4k48oggoo400 is ready. 🟢 Open Preview | Open Build Logs Last updated at: 2025-11-05 10:18:41 CET |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the GasLimitStorageGrowthRatio parameter from 1 to 366 across three runtime configurations (peaq, peaq-dev, and krest), aligning with the Moonbeam implementation as referenced in the existing comments.
- Changed
GasLimitStorageGrowthRatiofrom 1 to 366 to match the documented Moonbeam formula
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| runtime/peaq/src/lib.rs | Updated GasLimitStorageGrowthRatio to 366 for the peaq runtime |
| runtime/peaq-dev/src/lib.rs | Updated GasLimitStorageGrowthRatio to 366 for the peaq-dev runtime |
| runtime/krest/src/lib.rs | Updated GasLimitStorageGrowthRatio to 366 for the krest runtime |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| /// In moonbeam, they setup as 366 and follow below formula: | ||
| /// The amount of gas per storage (in bytes): BLOCK_GAS_LIMIT / BLOCK_STORAGE_LIMIT | ||
| /// (15_000_000 / 40kb) | ||
| /// However, let us setup the value as 1 for now because we also has the did/storage bridge |
There was a problem hiding this comment.
The comment is now outdated and contradicts the code. The value is no longer set to 1, so the comment should be updated to reflect that the value has been set to 366 or the comment should be removed.
| /// In moonbeam, they setup as 366 and follow below formula: | ||
| /// The amount of gas per storage (in bytes): BLOCK_GAS_LIMIT / BLOCK_STORAGE_LIMIT | ||
| /// (15_000_000 / 40kb) | ||
| /// However, let us setup the value as 1 for now because we also has the did/storage bridge |
There was a problem hiding this comment.
The comment is now outdated and contradicts the code. The value is no longer set to 1, so the comment should be updated to reflect that the value has been set to 366 or the comment should be removed.
| /// In moonbeam, they setup as 366 and follow below formula: | ||
| /// The amount of gas per storage (in bytes): BLOCK_GAS_LIMIT / BLOCK_STORAGE_LIMIT | ||
| /// (15_000_000 / 40kb) | ||
| /// However, let us setup the value as 1 for now because we also has the did/storage bridge |
There was a problem hiding this comment.
The comment is now outdated and contradicts the code. The value is no longer set to 1, so the comment should be updated to reflect that the value has been set to 366 or the comment should be removed.
GasLimitStorageGrowthRatioto 366 as suggested