Fix downloader plugin by trevin-j · Pull Request #4069 · pear-devs/pear-desktop

trevin-j · 2025-11-06T01:24:33Z

TLDR; the only way to fix the downloader is to upgrade youtubei.js to version 16 and specify a js interpreter.

As this comment says, the current hardcoded player id (from #3973) doesn't work anymore. At the moment, the downloader plugin won't work.

I upgraded youtubei.js to version 16, added in the snippet shown here (specifying a js interpreter), and got the downloads to work again.

Changes:

Remove hard-coded player_id
- The specific player_id is blocked now
Update youtubei.js dependency to version 16 (fixes download issues)
Specify js interpreter for sig function stuff

* Remove hard-coded player_id * The specific player_id is blocked now * Update youtubei.js dependency to version 16 (fixes download issues) * Specify js interpreter for sig function stuff

github-actions · 2025-11-06T01:25:34Z

 );
 const ffmpegMutex = new Mutex();

+Platform.shim.eval = async (data: Types.BuildScriptResult, env: Record<string, Types.VMPrimative>) => {


🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Replace data:·Types.BuildScriptResult,·env:·Record<string,·Types.VMPrimative> with ⏎··data:·Types.BuildScriptResult,⏎··env:·Record<string,·Types.VMPrimative>,⏎

Suggested change

Platform.shim.eval = async (data: Types.BuildScriptResult, env: Record<string, Types.VMPrimative>) => {

Platform.shim.eval = async (

data: Types.BuildScriptResult,

env: Record<string, Types.VMPrimative>,

) => {

github-actions · 2025-11-06T01:25:34Z

 );
 const ffmpegMutex = new Mutex();

+Platform.shim.eval = async (data: Types.BuildScriptResult, env: Record<string, Types.VMPrimative>) => {


🚫 [eslint] <@typescript-eslint/require-await> _{reported by reviewdog 🐶}
Async arrow function has no 'await' expression.

github-actions · 2025-11-06T01:25:35Z

+Platform.shim.eval = async (data: Types.BuildScriptResult, env: Record<string, Types.VMPrimative>) => {
+  const properties = [];
+
+  if(env.n) {


🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Insert ·

Suggested change

if(env.n) {

if (env.n) {

github-actions · 2025-11-06T01:25:35Z

+  const properties = [];
+
+  if(env.n) {
+    properties.push(`n: exportedVars.nFunction("${env.n}")`)


🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Insert ;

Suggested change

properties.push(`n: exportedVars.nFunction("${env.n}")`)

properties.push(`n: exportedVars.nFunction("${env.n}")`);

github-actions · 2025-11-06T01:25:35Z

+  const properties = [];
+
+  if(env.n) {
+    properties.push(`n: exportedVars.nFunction("${env.n}")`)


🚫 [eslint] <stylistic/semi> _{reported by reviewdog 🐶}
Missing semicolon.

Suggested change

properties.push(`n: exportedVars.nFunction("${env.n}")`)

properties.push(`n: exportedVars.nFunction("${env.n}")`);

github-actions · 2025-11-06T01:25:36Z

+
+  const code = `${data.output}\nreturn { ${properties.join(', ')} }`;
+
+  return new Function(code)();


🚫 [eslint] <@typescript-eslint/no-unsafe-return> _{reported by reviewdog 🐶}
Unsafe return of a value of type any.

github-actions · 2025-11-06T01:25:36Z

+
+  const code = `${data.output}\nreturn { ${properties.join(', ')} }`;
+
+  return new Function(code)();


🚫 [eslint] <@typescript-eslint/no-implied-eval> _{reported by reviewdog 🐶}
Implied eval. Do not use the Function constructor to create functions.

github-actions · 2025-11-06T01:25:36Z

+
+  const code = `${data.output}\nreturn { ${properties.join(', ')} }`;
+
+  return new Function(code)();


🚫 [eslint] <@typescript-eslint/no-unsafe-call> _{reported by reviewdog 🐶}
Unsafe call of a(n) Function typed value.

github-actions · 2025-11-06T01:25:36Z

+  const code = `${data.output}\nreturn { ${properties.join(', ')} }`;
+
+  return new Function(code)();
+}


🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Insert ;

Suggested change

}

};

github-actions · 2025-11-06T01:25:36Z

+  const code = `${data.output}\nreturn { ${properties.join(', ')} }`;
+
+  return new Function(code)();
+}


🚫 [eslint] <stylistic/semi> _{reported by reviewdog 🐶}
Missing semicolon.

Suggested change

}

};

rabid-sausage · 2025-11-17T23:33:41Z

I can confirm this works, manually applied the changes and built a working version and can now download without issue.
Myself prior to reading this, I got as far as upgrading youtubei.js to 16 and including meriyah, but could not wok out what to do with the required script, where to insert it, but can see from what you have done it was actually rather simple (still do not know what the script does). The Player ID fix was a quick get-around a bigger problem, found that out on other groups who first offered the Player ID solution.

Thanks for you effort and showing what you have done.

It will be interesting to see if this get pushed in to the next build, as it looks like some parties like youtubei.js, projects that use their code and others which operate similar are now not including this type of function in pre-compiled downloads, requiring individual users to manually insert/adjust the code and build a working copy themselves to gain this and other functions. Maybe a method avoiding getting in to trouble directly.

LyonDR · 2025-11-21T18:36:05Z

I can confirm this works, manually applied the changes and built a working version and can now download without issue. Myself prior to reading this, I got as far as upgrading youtubei.js to 16 and including meriyah, but could not wok out what to do with the required script, where to insert it, but can see from what you have done it was actually rather simple (still do not know what the script does). The Player ID fix was a quick get-around a bigger problem, found that out on other groups who first offered the Player ID solution.

Thanks for you effort and showing what you have done.

It will be interesting to see if this get pushed in to the next build, as it looks like some parties like youtubei.js, projects that use their code and others which operate similar are now not including this type of function in pre-compiled downloads, requiring individual users to manually insert/adjust the code and build a working copy themselves to gain this and other functions. Maybe a method avoiding getting in to trouble directly.

Can you pass me your app, please?

ArjixWasTaken · 2025-11-26T19:20:46Z

LGTM, thanks for your contribution!

its-iris · 2025-11-29T20:11:37Z

I know the eval example is from the youtubei.js repo but wouldn't it be better to run the code using node:vm with an empty context like here ? It's still not good enough to run untrusted code but it should be the best option without an extra dependency.

ArjixWasTaken · 2025-11-29T20:38:50Z

@its-iris would you like to open a PR?

LyonDR · 2025-12-01T15:02:34Z

Can someone explained how to do that like step by step for noobs?

I recommend asking chatgpt 😅 That's what I did.

You send him the link to this PR and ask him to guide you on how to apply the fix.

JellyBrick · 2026-02-01T15:39:00Z

I know the eval example is from the youtubei.js repo but wouldn't it be better to run the code using node:vm with an empty context like here ? It's still not good enough to run untrusted code but it should be the best option without an extra dependency.

I've tried several approaches, but BGUtils doesn't work properly in a node:vm environment. (It might look like it's working, but the values aren't valid)

fix(downloader): update youtubei.js and remove player_id

060b40b

* Remove hard-coded player_id * The specific player_id is blocked now * Update youtubei.js dependency to version 16 (fixes download issues) * Specify js interpreter for sig function stuff

github-actions Bot reviewed Nov 6, 2025

View reviewed changes

Copilot AI mentioned this pull request Nov 9, 2025

Upgrade youtubei.js to 16.0.1 and fix downloader plugin Daksh777/youtube-music#2

Merged

n1d3v mentioned this pull request Nov 25, 2025

[Bug]: Downloader reports a non 2xx error, even with the latest source commit. #4110

Closed

5 tasks

Merge branch 'master' into master

69f377d

ArjixWasTaken merged commit 4fba3ff into pear-devs:master Nov 26, 2025
1 check failed

enzo-quirici mentioned this pull request Dec 24, 2025

[Bug]: Can't Download any Music #4158

Closed

5 tasks

JellyBrick added bug Something isn't working dependencies Pull requests that update a dependency file labels Feb 1, 2026

	properties.push(`n: exportedVars.nFunction("${env.n}")`)
	properties.push(`n: exportedVars.nFunction("${env.n}")`);


		const code = `${data.output}\nreturn { ${properties.join(', ')} }`;

		return new Function(code)();

Conversation

trevin-j commented Nov 6, 2025

Uh oh!

github-actions Bot Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

rabid-sausage commented Nov 17, 2025

Uh oh!

LyonDR commented Nov 21, 2025

Uh oh!

ArjixWasTaken commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

its-iris commented Nov 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ArjixWasTaken commented Nov 29, 2025

Uh oh!

LyonDR commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JellyBrick commented Feb 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ArjixWasTaken commented Nov 26, 2025 •

edited

Loading

its-iris commented Nov 29, 2025 •

edited

Loading

LyonDR commented Dec 1, 2025 •

edited

Loading