fix: prevent media key global shortcuts from breaking Windows SMTC fl…#4310
Open
Thundia2 wants to merge 1 commit intopear-devs:masterfrom
Open
fix: prevent media key global shortcuts from breaking Windows SMTC fl…#4310Thundia2 wants to merge 1 commit intopear-devs:masterfrom
Thundia2 wants to merge 1 commit intopear-devs:masterfrom
Conversation
…yout On Windows, registering globalShortcut for MediaPlayPause/MediaNextTrack/ MediaPreviousTrack intercepts these key events at the OS level before they reach the SMTC (System Media Transport Controls) pipeline. This causes the Windows 11 taskbar media flyout to disappear entirely. Skip registering global shortcuts for media keys on Windows and let Chromium's built-in MediaSessionService handle them through SMTC instead. Also guard the custom global shortcut mapping against media key accelerators on Windows to prevent the same issue through user configuration. https://claude.ai/code/session_01GEBpbF58htWkfQRbH2Eysa
JellyBrick
added
the
electron-issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…yout
On Windows, registering globalShortcut for MediaPlayPause/MediaNextTrack/ MediaPreviousTrack intercepts these key events at the OS level before they reach the SMTC (System Media Transport Controls) pipeline. This causes the Windows 11 taskbar media flyout to disappear entirely.
Skip registering global shortcuts for media keys on Windows and let Chromium's built-in MediaSessionService handle them through SMTC instead. Also guard the custom global shortcut mapping against media key accelerators on Windows to prevent the same issue through user configuration.
https://claude.ai/code/session_01GEBpbF58htWkfQRbH2Eysa