Skip to content

Improve build hygiene and filename utility coverage - #214

Open
fred-vu wants to merge 1 commit into
peazip:sourcesfrom
fred-vu:improve-build-hygiene-filename-utils
Open

Improve build hygiene and filename utility coverage#214
fred-vu wants to merge 1 commit into
peazip:sourcesfrom
fred-vu:improve-build-hygiene-filename-utils

Conversation

@fred-vu

@fred-vu fred-vu commented Jun 23, 2026

Copy link
Copy Markdown

Improve build hygiene and filename utility coverage

@fred-vu fred-vu closed this Jun 23, 2026
@fred-vu fred-vu reopened this Jun 23, 2026
@peazip

peazip commented Jun 23, 2026

Copy link
Copy Markdown
Owner

Thank you very much for the commit, it contains various good suggestions.
However, as it covers various distinct topics, I would prefer to test each logical portion separately instead of merging all changes at once - especially as the PeaZip.ShellEx part was originally user contributed (so it is quite outside my usual coding style comfort zone), and the file name routines being security-sensitive and needing extensive testing for smallest changes.
I'll look deeper at the changes to organize the testing and deployment of the various contributions in the code base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants