Sync with pebble main branch #144
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hexxeh
requested changes
Apr 7, 2025
There was a problem hiding this comment.
It is pretty difficult to effectively review a 4,000 line PR, could you split this into multiple PRs where the commits have messages that clearly define what is being added/changed (ie, most of them should probably mention sifli as a commit message prefix.
I also think you may not want to name your board after the HW platform, in the same way snowy is not called stm32f4 and asterix is not called nrf52.
It'd also be great to understand as context what boards/devices you're intending to use this for, if you can share this.
This allows NimBLE to always use the same, randomly generated, IRK if RPA is ever used. LTK generation is not supported, this way, NimBLE will generate a random LTK every time, not based on any root key. Note that ble_root_keys_get_and_generate_if_needed is not called when using NimBLE because the entropy source we use is the controller one (via ble_hs_hci_rand), so it can't be accessed before the host/controller are running. Signed-off-by: Gerard Marull-Paretas <[email protected]>
This is now handled by the BLE stack, also using the controller as a source of entropy. Signed-off-by: Gerard Marull-Paretas <[email protected]>
So that CI is happy. Signed-off-by: Gerard Marull-Paretas <[email protected]>
Note that some drivers are still stubs (added FIXME comments). Some PebbleOS abstractions likely need a rethink, as they are STM32-biased. Signed-off-by: Gerard Marull-Paretas <[email protected]>
Signed-off-by: Gerard Marull-Paretas <[email protected]>
Asterix uses GD25LQ255E. Signed-off-by: Gerard Marull-Paretas <[email protected]>
File is never compiled for nRF. Signed-off-by: Gerard Marull-Paretas <[email protected]>
Ref. https://www.jedec.org/standards-documents/docs/jesd216b Signed-off-by: Gerard Marull-Paretas <[email protected]>
Signed-off-by: Gerard Marull-Paretas <[email protected]>
(single/dual/quad op codes). Also rename page_program to pp for consistency with the new additions. Signed-off-by: Gerard Marull-Paretas <[email protected]>
Signed-off-by: Gerard Marull-Paretas <[email protected]>
Signed-off-by: Gerard Marull-Paretas <[email protected]>
Signed-off-by: Gerard Marull-Paretas <[email protected]>
Signed-off-by: Gerard Marull-Paretas <[email protected]>
Signed-off-by: Gerard Marull-Paretas <[email protected]>
Signed-off-by: Gerard Marull-Paretas <[email protected]>
Signed-off-by: Gerard Marull-Paretas <[email protected]>
So that CI is happy when doing changes. Signed-off-by: Gerard Marull-Paretas <[email protected]>
Signed-off-by: Gerard Marull-Paretas <[email protected]>
Signed-off-by: Gerard Marull-Paretas <[email protected]>
Signed-off-by: Gerard Marull-Paretas <[email protected]>
So CI is happy. Signed-off-by: Gerard Marull-Paretas <[email protected]>
So CI is happy. Signed-off-by: Gerard Marull-Paretas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.