fw/flash_region: add flash region for GD25LQ255E #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until now Silk layout was used, so only 8MB were effectively available instead of 32MB. Signed-off-by: Gerard Marull-Paretas <[email protected]>
gmarull
force-pushed
the
fix-asterix-flash-layout
branch
from
69e96a3 to
414ea22
Compare
So that CI is happy. Signed-off-by: Gerard Marull-Paretas <[email protected]>
Hexxeh
reviewed
Apr 15, 2025
| #define FLASH_REGION_DEF(MACRO, arg) \ | ||
| MACRO(FIRMWARE_SCRATCH, 0x0100000 /* 1024k */, arg) /* 0x0 - 0x0100000 */ \ | ||
| MACRO(SYSTEM_RESOURCES_BANK_0, 0x0080000 /* 512K */, arg) /* 0x0100000 - 0x0180000 */ \ | ||
| MACRO(SYSTEM_RESOURCES_BANK_1, 0x0080000 /* 512K */, arg) /* 0x0180000 - 0x0200000 */ \ |
There was a problem hiding this comment.
You'll probably want to make this bigger given your flash is bigger, same for filesystem.
There was a problem hiding this comment.
Agreed, we'll likely review this in the near future, just expanded file system to cover for the whole flash.
Hexxeh
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now Silk layout was used, so only 8MB were effectively available instead of 32MB.