-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Fixes media upload to channels #5697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fixes media upload to channels #5697
Conversation
Ensures correct media upload to channels by using the mimetype from mediaInfo, rather than the file, when creating OpaqueData. Also, it replaces the call to the function getRandomFilehash with the value of the function to retrieve the correct token.
tlgsn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it works well. Thank you.
tahafatih
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its worked. Thank you.
|
Can confirm, works like a charm! |
|
@tahafatih @tlgsn @danpasecinic Can you help merge this PR? |
|
@owen800q we can't merge PR without at least 2 reviews by reviewers with write access to repository. |
Summary
Fix media upload for channels by correcting two issues in
processMediaData:mediaInfo.mimetypeinstead offile.typewhen creating opaque data, ensuring the correct MIME type is passedgetRandomFilehashas a function reference instead of invoking it immediately withgetRandomFilehash()Changes
Utils.js:449: Fixed MIME type parameter for
OpaqueData.createFromData