query acme

Author: martinatpeek

lib/peek_app_sdk.ex

@@ -86,15 +86,11 @@ defmodule PeekAppSDK do
   defdelegate query_peek_pro(install_id, gql_query, gql_variables \\ %{}, config_id \\ nil),
     to: PeekAppSDK.Client
 
-  defdelegate query_platform(install_id, method, url, body),
-    to: PeekAppSDK.Client
-
   @doc """
   Queries a platform API and returns the raw response body.
-  Unlike `query_platform/4`, this does not expect a `{data: ...}` wrapper around the response.
   """
-  @spec query_platform_raw(String.t(), atom(), String.t(), map()) ::
+  @spec query_platform(String.t(), atom(), String.t(), map()) ::
           {:ok, map()} | {:error, list()} | {:error, {integer(), any()}}
-  defdelegate query_platform_raw(install_id, method, url, body),
+  defdelegate query_platform(install_id, method, url, body),
     to: PeekAppSDK.Client
 end

lib/peek_app_sdk/client.ex

@@ -77,35 +77,12 @@ defmodule PeekAppSDK.Client do
     end
   end
 
-  def query_platform(install_id, method, url, body_params) do
-    config = Config.get_config(nil)
-    peek_api_key = config.peek_api_key
-
-    case Tesla.request(client(),
-           method: method,
-           url: url,
-           body: body_params,
-           headers: headers(install_id, nil, peek_api_key)
-         ) do
-      {:ok, %Tesla.Env{status: 200, body: %{errors: [_error | _rest] = errors}}} ->
-        {:error, errors}
-
-      {:ok, %Tesla.Env{status: 200, body: %{data: data}}} ->
-        {:ok, data}
-
-      {:ok, %Tesla.Env{status: status, body: body}} ->
-        Logger.error("Unexpected Platform response when hitting #{url} - (#{status}): #{inspect(body)}")
-        {:error, status}
-    end
-  end
-
   @doc """
   Queries a platform API and returns the raw response body.
-  Unlike `query_platform/4`, this does not expect a `{data: ...}` wrapper around the response.
   """
-  @spec query_platform_raw(String.t(), atom(), String.t(), map()) ::
+  @spec query_platform(String.t(), atom(), String.t(), map()) ::
           {:ok, map()} | {:error, list()} | {:error, {integer(), any()}}
-  def query_platform_raw(install_id, method, url, body_params) do
+  def query_platform(install_id, method, url, body_params) do
     config = Config.get_config(nil)
     peek_api_key = config.peek_api_key
 

test/peek_app_sdk/client_test.exs

@@ -225,89 +225,26 @@ defmodule PeekAppSDK.ClientTest do
   end
 
   describe "query_platform/4" do
-    test "successfully queries platform with GET method using full URL" do
+    test "successfully returns raw response body for 200 status" do
       install_id = "test_install_id"
       url = "https://api.example.com/some/endpoint"
       body_params = %{}
-      response_data = %{result: "success"}
+      response_body = %{result: "success", other_field: "value"}
 
       Tesla.Adapter.Finch
       |> Mimic.stub(:call, fn env, _opts ->
         assert env.method == :get
-        assert env.url == "https://api.example.com/some/endpoint"
+        assert env.url == url
         assert Jason.decode!(env.body) == body_params
 
         assert Enum.any?(env.headers, fn {k, v} ->
                  k == "X-Peek-Auth" && String.starts_with?(v, "Bearer ")
                end)
 
-        {:ok, %Tesla.Env{status: 200, body: %{data: response_data}}}
-      end)
-
-      assert {:ok, ^response_data} = PeekAppSDK.query_platform(install_id, :get, url, body_params)
-    end
-
-    test "successfully queries platform with POST method and body" do
-      install_id = "test_install_id"
-      url = "https://api.example.com/api/resource"
-      body_params = %{"key" => "value"}
-      response_data = %{created: true}
-
-      Tesla.Adapter.Finch
-      |> Mimic.stub(:call, fn env, _opts ->
-        assert env.method == :post
-        assert env.url == "https://api.example.com/api/resource"
-        assert Jason.decode!(env.body) == body_params
-
-        {:ok, %Tesla.Env{status: 200, body: %{data: response_data}}}
-      end)
-
-      assert {:ok, ^response_data} = Client.query_platform(install_id, :post, url, body_params)
-    end
-
-    test "handles error response" do
-      install_id = "test_install_id"
-      url = "https://api.example.com/api/resource"
-
-      Tesla.Adapter.Finch
-      |> Mimic.stub(:call, fn _env, _opts ->
-        {:ok, %Tesla.Env{status: 404, body: %{error: "Not found"}}}
-      end)
-
-      assert {:error, 404} = Client.query_platform(install_id, :get, url, %{})
-    end
-
-    test "bubbles up errors when status is 200 but errors key is present" do
-      install_id = "test_install_id"
-      url = "https://api.example.com/api/resource"
-
-      errors = [%{message: "Validation failed"}]
-
-      Tesla.Adapter.Finch
-      |> Mimic.stub(:call, fn _env, _opts ->
-        {:ok, %Tesla.Env{status: 200, body: %{errors: errors}}}
-      end)
-
-      assert {:error, ^errors} = Client.query_platform(install_id, :post, url, %{})
-    end
-  end
-
-  describe "query_platform_raw/4" do
-    test "successfully returns raw response body for 200 status" do
-      install_id = "test_install_id"
-      url = "https://api.example.com/some/endpoint"
-      body_params = %{}
-      response_body = %{result: "success", other_field: "value"}
-
-      Tesla.Adapter.Finch
-      |> Mimic.stub(:call, fn env, _opts ->
-        assert env.method == :get
-        assert env.url == url
-
         {:ok, %Tesla.Env{status: 200, body: response_body}}
       end)
 
-      assert {:ok, ^response_body} = Client.query_platform_raw(install_id, :get, url, body_params)
+      assert {:ok, ^response_body} = PeekAppSDK.query_platform(install_id, :get, url, body_params)
     end
 
     test "successfully returns raw response body for 201 status" do
@@ -320,11 +257,12 @@ defmodule PeekAppSDK.ClientTest do
       |> Mimic.stub(:call, fn env, _opts ->
         assert env.method == :post
         assert env.url == url
+        assert Jason.decode!(env.body) == body_params
 
         {:ok, %Tesla.Env{status: 201, body: response_body}}
       end)
 
-      assert {:ok, ^response_body} = Client.query_platform_raw(install_id, :post, url, body_params)
+      assert {:ok, ^response_body} = Client.query_platform(install_id, :post, url, body_params)
     end
 
     test "handles error response with status and body tuple" do
@@ -337,7 +275,7 @@ defmodule PeekAppSDK.ClientTest do
         {:ok, %Tesla.Env{status: 404, body: error_body}}
       end)
 
-      assert {:error, {404, ^error_body}} = Client.query_platform_raw(install_id, :get, url, %{})
+      assert {:error, {404, ^error_body}} = Client.query_platform(install_id, :get, url, %{})
     end
 
     test "bubbles up errors when status is 200 but errors key is present" do
@@ -351,7 +289,7 @@ defmodule PeekAppSDK.ClientTest do
         {:ok, %Tesla.Env{status: 200, body: %{errors: errors}}}
       end)
 
-      assert {:error, ^errors} = Client.query_platform_raw(install_id, :post, url, %{})
+      assert {:error, ^errors} = Client.query_platform(install_id, :post, url, %{})
     end
   end
 

test/peek_app_sdk/ui/odyssey_test.exs

@@ -168,8 +168,7 @@ defmodule PeekAppSDK.UI.OdysseyTest do
 
       assert html =~ "<fieldset"
       assert html =~ "class=\"fieldset mb-2\""
-      assert html =~ "<label>"
-      assert html =~ ~r/<span class="label mb-1">.*Time Unit.*<\/span>/s
+      assert html =~ ~r/<span class="label mb-1 block">.*Time Unit.*<\/span>/s
       assert html =~ "class=\"inline-flex rounded-lg\""
     end
 
@@ -189,8 +188,7 @@ defmodule PeekAppSDK.UI.OdysseyTest do
 
       assert html =~ "<fieldset"
       assert html =~ "class=\"fieldset mb-2\""
-      assert html =~ "<label>"
-      assert html =~ ~r/<span class="label mb-1">.*Communication Channel.*<\/span>/s
+      assert html =~ ~r/<span class="label mb-1 block">.*Communication Channel.*<\/span>/s
       assert html =~ "Email"
       assert html =~ "Text Message"
       # Should have hidden input for form integration