Skip to content

Default to NOT posting installs/uninstalls to slack #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
coladarci merged 1 commit into from
Aug 11, 2025
Merged

Default to NOT posting installs/uninstalls to slack #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions lib/peek_app_sdk/metrics.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,11 @@ defmodule PeekAppSDK.Metrics do
This module provides functions for tracking metrics to Ahem.
"""

defdelegate track_install(external_refid, name, is_test), to: PeekAppSDK.Metrics.Client
defdelegate track_uninstall(external_refid, name, is_test), to: PeekAppSDK.Metrics.Client
defdelegate track_install(external_refid, name, is_test, opts \\ []),
to: PeekAppSDK.Metrics.Client

defdelegate track_uninstall(external_refid, name, is_test, opts \\ []),
to: PeekAppSDK.Metrics.Client

@doc """
Tracks an event with the given event ID and payload.
Expand Down
10 changes: 6 additions & 4 deletions lib/peek_app_sdk/metrics/client.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,8 @@ defmodule PeekAppSDK.Metrics.Client do
{:ok, %{...}}

"""
def track_install(external_refid, name, is_test) do
def track_install(external_refid, name, is_test, opts \\ []) do
post_message = if(Keyword.get(opts, :post_message, false), do: "#{name} installed")
usage_display = if is_test, do: "New TEST App Installs", else: "New App Installs"

do_post!(%{
Expand All @@ -71,7 +72,7 @@ defmodule PeekAppSDK.Metrics.Client do
anonymousId: external_refid,
usageDisplay: usage_display,
usageDetails: name,
postMessage: "#{name} installed",
postMessage: post_message,
customFields: base_custom_fields(name, external_refid, is_test)
})
end
Expand All @@ -91,7 +92,8 @@ defmodule PeekAppSDK.Metrics.Client do
{:ok, %{...}}

"""
def track_uninstall(external_refid, name, is_test) do
def track_uninstall(external_refid, name, is_test, opts \\ []) do
post_message = if(Keyword.get(opts, :post_message, false), do: "#{name} uninstalled")
usage_display = if is_test, do: "New TEST App Uninstalls", else: "New App Uninstalls"

do_post!(%{
Expand All @@ -100,7 +102,7 @@ defmodule PeekAppSDK.Metrics.Client do
anonymousId: external_refid,
usageDisplay: usage_display,
usageDetails: name,
postMessage: "#{name} uninstalled",
postMessage: post_message,
customFields: base_custom_fields(name, external_refid, is_test)
})
end
Expand Down
4 changes: 2 additions & 2 deletions test/peek_app_sdk/metrics/client_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ defmodule PeekAppSDK.Metrics.ClientTest do
{:ok, %Tesla.Env{status: 202}}
end)

assert {:ok, _} = Client.track_install(external_refid, name, is_test)
assert {:ok, _} = Client.track_install(external_refid, name, is_test, post_message: true)
end

test "sends correct payload for test installation" do
Expand Down Expand Up @@ -151,7 +151,7 @@ defmodule PeekAppSDK.Metrics.ClientTest do
{:ok, %Tesla.Env{status: 202}}
end)

assert {:ok, _} = Client.track_uninstall(external_refid, name, is_test)
assert {:ok, _} = Client.track_uninstall(external_refid, name, is_test, post_message: true)
end

test "sends correct payload for test uninstallation" do
Expand Down