Feature/more components - #28
Merged
Merged
Conversation
coladarci
force-pushed
the
feature/more-components
branch
from
November 4, 2025 19:42
1871eb7 to
c0ed72a
Compare
coladarci
commented
Nov 4, 2025
| attr :name, :string, required: true | ||
| attr :class, :string, default: "size-4" | ||
|
|
||
| def odyssey_icon(%{name: "hero-" <> _} = assigns) do |
Collaborator
Author
There was a problem hiding this comment.
This is somewhat temporary. I'd like to delegate to the our odyssey icons for non hero-icons but I haven't tested yet to see if they are 1:1 w/ each other from a sizing perspective.
I need SOMETHING for hero icons in here since we need an icon for one of the components in this file and I can't depend on "icon" being a function component since it's in core components which is intentionally not part of peek app sdk.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bring in
toggle_button+toggle_button_inputfrom recent app for sharability.Demo coming soon.