fix(aiv): harden state manager — memory caps, path validation, 404s#10
Open
fix(aiv): harden state manager — memory caps, path validation, 404s#10
Conversation
… 404s Cap touchedFiles at 500 per session and strategyChanges at 50. Add isFilePath validation to reject URLs, garbage, and overly long strings. Add periodic idle-session sweep (30min TTL, 5min interval). Return 404 for non-existent sessions on GET /aiv/intent/:sessionID. Addresses P0/P1 hardening tasks from review notes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
touchedFilesat 500 entries/session andstrategyChangesat 50 entries/session to prevent unbounded memory growthisFilePath()validation to reject URLs (http://,https://,//), strings with tabs/newlines, and strings >500 charsGET /aiv/intent/:sessionIDwhen session doesn't exist (was returning synthetic empty intent)Addresses P0 "Cap memory growth" + "Fix isFilePath" and P1 "Return 404 for non-existent sessions" from review hardening tasks.
Test plan
isFilePathrejects URLs, tab/newline strings, and long stringsisFilePathaccepts valid paths (relative, absolute, tilde)GET /aiv/intent/:nonexistentreturns 404🤖 Generated with Claude Code