Skip to content

add onnxscript dependency and split up PyTorch tests#822

Merged
StijnKas merged 5 commits into
masterfrom
add-onnxscript-dep
Jun 4, 2026
Merged

add onnxscript dependency and split up PyTorch tests#822
StijnKas merged 5 commits into
masterfrom
add-onnxscript-dep

Conversation

@jmelburg

@jmelburg jmelburg commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

ONNXModel.from_pytorch requires onnxscript. This wasn't picked up before because the relevant tests were skipped:

@pytest.mark.skipif(not _pytorch_available(), reason="torch not installed")

Now that #780 pulls PyTorch into the tests dependencies, the tests trigger, surfacing the issue.

@codecov

codecov Bot commented Jun 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.45%. Comparing base (3275cc6) to head (a335a52).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #822      +/-   ##
==========================================
- Coverage   89.29%   88.45%   -0.84%     
==========================================
  Files         128      128              
  Lines       10665    10665              
==========================================
- Hits         9523     9434      -89     
- Misses       1142     1231      +89     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jmelburg jmelburg marked this pull request as draft June 4, 2026 10:00
@jmelburg jmelburg changed the title add onnxscript dep add onnxscript dependency and split up PyTorch tests Jun 4, 2026
@jmelburg jmelburg marked this pull request as ready for review June 4, 2026 12:31
@jmelburg jmelburg requested a review from StijnKas June 4, 2026 12:44
@StijnKas StijnKas merged commit cb2420a into master Jun 4, 2026
33 of 34 checks passed
@StijnKas StijnKas deleted the add-onnxscript-dep branch June 4, 2026 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants