Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patches for bugs introduced in 2.4 and 2.5 releases #187

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ianthetechie
Copy link


Here's the reason for this change 🚀

Versions 2.4.0 and 2.5.0 respectively introduced some issues, making certain kinds of input either unparseable or unsuitable for geocoding.

Demo links:


Here's what actually got changed 👏

  • Added a "not" restriction in one of the venue classification rules. Via reverse engineering, I determined that this was responsible for the "Main St Seattl" regression.
  • Perhaps slightly more controversial, I removed a row from dictionaries/nb/concatenated_suffixes_separable.txt. This appears to be significantly interfering with Spanish addresses.

Here's how others can test the changes 👀

I've added unit tests for both cases. Additionally, I swapped in the branch for the pelias API and verified that all tests pass there. I actually discovered this while tinkering with some other things and realizing that like 100 API tests (slightly inflated in scope since it's char by char searches) fail as-is ☠️

I think longer term it'd probably be a good idea to harmonize that code and testing process a bit. Right now it's disjoint because the API has a second layer of processing logic on top of this lib, and that complicates testing, which is probably why these have been lurking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant