Patches for bugs introduced in 2.4 and 2.5 releases #187
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's the reason for this change 🚀
Versions 2.4.0 and 2.5.0 respectively introduced some issues, making certain kinds of input either unparseable or unsuitable for geocoding.
Demo links:
Here's what actually got changed 👏
dictionaries/nb/concatenated_suffixes_separable.txt
. This appears to be significantly interfering with Spanish addresses.Here's how others can test the changes 👀
I've added unit tests for both cases. Additionally, I swapped in the branch for the pelias API and verified that all tests pass there. I actually discovered this while tinkering with some other things and realizing that like 100 API tests (slightly inflated in scope since it's char by char searches) fail as-is ☠️
I think longer term it'd probably be a good idea to harmonize that code and testing process a bit. Right now it's disjoint because the API has a second layer of processing logic on top of this lib, and that complicates testing, which is probably why these have been lurking.