DiscordWebhooks #1355
DiscordWebhooks #1355
Conversation
|
|
JoanFo1456
force-pushed
the
feature/DiscordWebhook
branch
from
f28cb83 to
3286514
Compare
app/Filament/Admin/Resources/WebhookResource/Pages/EditWebhookConfiguration.php
Outdated
Show resolved
Hide resolved
app/Filament/Admin/Resources/WebhookResource/Pages/CreateWebhookConfiguration.php
Outdated
Show resolved
Hide resolved
Removed easterEgg function Co-authored-by: Lance Pioch <[email protected]>
|
Lance, if you get the chance let me know if everything is good or not, my suggestion here is adding once again faker to show example values on the embed, instead of giving the values directly. |
app/Filament/Admin/Resources/WebhookResource/Pages/EditWebhookConfiguration.php
Outdated
Show resolved
Hide resolved
resources/views/filament/admin/widgets/discord-preview.blade.php
Outdated
Show resolved
Hide resolved
resources/views/filament/admin/widgets/discord-preview.blade.php
Outdated
Show resolved
Hide resolved
resources/views/filament/admin/widgets/discord-preview.blade.php
Outdated
Show resolved
Hide resolved
resources/views/filament/admin/widgets/discord-preview.blade.php
Outdated
Show resolved
Hide resolved
resources/views/filament/admin/widgets/discord-preview.blade.php
Outdated
Show resolved
Hide resolved
|
I have used a phpstan ignore next line on DiscordPreview, since i didn't quite found a way, i'm open to suggestions... |
app/Filament/Admin/Resources/WebhookResource/Pages/EditWebhookConfiguration.php
Outdated
Show resolved
Hide resolved
|
Still can't be merged, since the change you asked headers stopped being sent, i'm looking at it. |
|
Now you can take a look and everything... |
Did Lance's suggestion. Co-authored-by: Lance Pioch <[email protected]>
|
Everything seems good to be merged, so if you guys want, go ahead. |
| ]) | ||
| ->afterStateHydrated(function ($state, Set $set, Get $get) { | ||
| if ($state === WebhookType::Discord->value) { | ||
| AlertBanner::make() |
There was a problem hiding this comment.
Since this, seems that something doesn't like it, since the banner never gets shown (the code is running), so I don't actually know what happened.
There was a problem hiding this comment.
That's a known issue atm, "dynamic" alert banners (aka banners created after the page is loaded) need a page refresh to show.
The main purpose of the id is to prevent the same banner showing multiple times.
There was a problem hiding this comment.
Oh, okay. Also was a flag of mine, once I repaired it I saw that, that is sad though, that you need to reload to see the actual banner, maybe if I make the save now button restart page if it detects a change of type?
app/Filament/Admin/Resources/WebhookResource/Pages/EditWebhookConfiguration.php
Outdated
Show resolved
Hide resolved
database/migrations/2025_04_09_015500_add_webhook_configurations_type_column.php
Outdated
Show resolved
Hide resolved
|
You guys think is good enough to be on the panel? Or should I make some other changes |
After repairing some issues i had with my git, i suppose now is ready to work. (Did a pr before)
Some files probably have disappeared on another ones with the new changes recently, same some files probably need to be on another part, after all, this was a update following main but some files weren't removed at all...
I will make changes on it, making it less "draft" if this is accepted, only change that needs to be done at least i think is when saving to reload filament with the new changes.