Adding more translation strings for server panel (non-admin) #1418

JamesMCL44 · 2025-05-31T14:21:15Z

No description provided.

github-actions · 2025-05-31T14:21:29Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

SirEndii · 2025-05-31T14:24:01Z

Translation is all done on Crowdin. Please submit your translations here

JamesMCL44 · 2025-05-31T14:26:56Z

noted, but this pr is to add more translation strings related to the panel by server user, i.e., the console, file browser etc.
Please kindly check my coding before comment/reply, thanks.

SirEndii · 2025-05-31T14:30:34Z

Haha, sorry. I just saw the title and assumed there were translations, like with the other dozens of PRs

JamesMCL44 · 2025-05-31T14:31:30Z

I have read the CLA Document and I hereby sign the CLA

lancepioch

Please take out the Chinese translations, we use crowdin for translations

lancepioch

Thanks a bunch, just need to fix up these final keys and I think we're ready to go!

lancepioch · 2025-06-07T03:07:53Z

app/Enums/BackupStatus.php

@@ -32,6 +32,6 @@ public function getColor(): string

    public function getLabel(): string
    {
-        return str($this->value)->headline();
+        return trans('strings.backupstatus.'.str($this->value));


Spaces should be replaced with underscores! BackupStatus = backup_status or Backup Status for example.

Suggested change

return trans('strings.backupstatus.'.str($this->value));

return trans('strings.backup_status.'.str($this->value));

lancepioch · 2025-06-07T03:08:03Z

app/Enums/ContainerStatus.php

@@ -68,7 +68,7 @@ public function getColor(bool $hex = false): string

    public function getLabel(): string
    {
-        return str($this->value)->title();
+        return trans('strings.containerstatus.'.str($this->value));


Suggested change

return trans('strings.containerstatus.'.str($this->value));

return trans('strings.container_status.'.str($this->value));

lancepioch · 2025-06-07T03:08:15Z

app/Filament/Server/Pages/Console.php

@@ -152,20 +152,23 @@ protected function getHeaderActions(): array

        return [
            Action::make('start')
+                ->label(trans('strings.consolestatus.start'))


Suggested change

->label(trans('strings.consolestatus.start'))

->label(trans('strings.console_status.start'))

lancepioch · 2025-06-07T03:08:22Z

app/Filament/Server/Pages/Console.php

                ->color('primary')
                ->size(ActionSize::ExtraLarge)
                ->dispatch('setServerState', ['state' => 'start', 'uuid' => $server->uuid])
                ->authorize(fn () => auth()->user()->can(Permission::ACTION_CONTROL_START, $server))
                ->disabled(fn () => $server->isInConflictState() || !$this->status->isStartable())
                ->icon('tabler-player-play-filled'),
            Action::make('restart')
+                ->label(trans('strings.consolestatus.restart'))


Suggested change

->label(trans('strings.consolestatus.restart'))

->label(trans('strings.console_status.restart'))

lancepioch · 2025-06-07T03:08:27Z

app/Filament/Server/Pages/Console.php

                ->color('gray')
                ->size(ActionSize::ExtraLarge)
                ->dispatch('setServerState', ['state' => 'restart', 'uuid' => $server->uuid])
                ->authorize(fn () => auth()->user()->can(Permission::ACTION_CONTROL_RESTART, $server))
                ->disabled(fn () => $server->isInConflictState() || !$this->status->isRestartable())
                ->icon('tabler-reload'),
            Action::make('stop')
+                ->label(trans('strings.consolestatus.stop'))


Suggested change

->label(trans('strings.consolestatus.stop'))

->label(trans('strings.console_status.stop'))

lancepioch · 2025-06-07T03:12:00Z

lang/en/server/file.php

+        'unarchive' => 'Unarchive',
+        'unarchive_completed' => 'Unarchive completed',
+        'deletefileconfirm' => 'Delete file?',
+        'bulkmove' => [


Suggested change

'bulkmove' => [

'bulk_move' => [

lancepioch · 2025-06-07T03:12:06Z

lang/en/server/file.php

+        'archive_created' => 'Archive created',
+        'unarchive' => 'Unarchive',
+        'unarchive_completed' => 'Unarchive completed',
+        'deletefileconfirm' => 'Delete file?',


Suggested change

'deletefileconfirm' => 'Delete file?',

'delete_file_confirm' => 'Delete file?',

lancepioch · 2025-06-07T03:12:17Z

lang/en/server/file.php

+        'is_directory' => [
+            'title' => '<code> :file is a directory',
+        ],
+        'ignorefile' => [


Suggested change

'ignorefile' => [

'ignore_file' => [

lancepioch · 2025-06-07T03:12:23Z

lang/en/server/file.php

+return [
+    'edit' => [
+        'editing_title' => 'Editing :path',
+        'save&close' => 'Save & Close',


Suggested change

'save&close' => 'Save & Close',

'save_and_close' => 'Save & Close',

lancepioch · 2025-06-07T03:13:06Z

lang/en/server/allocation.php

+        'assignall' => 'Assign All',
+        'heading' => 'Invite User',
+        'actionlabel' => 'Invite',
+        'userinvited' => 'User Invited!',


Suggested change

'assignall' => 'Assign All',

'heading' => 'Invite User',

'actionlabel' => 'Invite',

'userinvited' => 'User Invited!',

'assign_all' => 'Assign All',

'heading' => 'Invite User',

'action_label' => 'Invite',

'user_invited' => 'User Invited!',

JamesMCL44 · 2025-06-07T05:09:35Z

Thanks for your comments and guides.
the pr is my first attempt to help out and therefore many are not in well structure
I now understand the structure of files and strings you wish to use.
Meanwhile, i do also notice some more texts could be converted to be translatable, I will work on those, fixing those you commented and also will try to minimise the Strings file so that users can locate the strings much easily.

I will work on it and finishing hopefully this Jun, please hold the merge for now.

rmartinoscar · 2025-06-08T16:21:38Z

app/Enums/BackupStatus.php

@@ -32,6 +32,6 @@ public function getColor(): string

    public function getLabel(): string
    {
-        return str($this->value)->headline();
+        return trans('strings.backupstatus.'.str($this->value));


Suggested change

return trans('strings.backupstatus.'.str($this->value));

return trans('strings.backupstatus.' . $this->value);

No need for str when not using headline since this Enum is a string

panel/app/Enums/BackupStatus.php

Line 9 in de166bc

enum BackupStatus: string implements HasColor, HasIcon, HasLabel

rmartinoscar · 2025-06-08T16:21:47Z

app/Enums/ContainerStatus.php

@@ -68,7 +68,7 @@ public function getColor(bool $hex = false): string

    public function getLabel(): string
    {
-        return str($this->value)->title();
+        return trans('strings.containerstatus.'.str($this->value));


Suggested change

return trans('strings.containerstatus.'.str($this->value));

return trans('strings.containerstatus.' . $this->value);

No need for str when not using headline since this Enum is a string

panel/app/Enums/BackupStatus.php

Line 9 in de166bc

enum BackupStatus: string implements HasColor, HasIcon, HasLabel

JamesMCL44 added 7 commits May 24, 2025 00:32

Added multiple translatable strings

456f1b5

Merge branch 'main' of https://github.com/JamesMCL44/panel

c09a0e5

fix error in translation

4b30b8e

Added multiple translatable strings

f72909c

Added translatable strings

f55f5c0

Added multiple translatable strings

623b184

Translated strings

6558673

JamesMCL44 changed the title ~~Translation~~ Adding more translation strings for server panel (non-admin) May 31, 2025

lancepioch requested changes Jun 3, 2025

View reviewed changes

Delete lang/zh-HK directory

f23d372

JamesMCL44 requested a review from lancepioch June 3, 2025 12:01

lancepioch requested changes Jun 7, 2025

View reviewed changes

lancepioch self-assigned this Jun 7, 2025

rmartinoscar marked this pull request as draft June 8, 2025 16:20

rmartinoscar reviewed Jun 8, 2025

View reviewed changes

rmartinoscar linked an issue Jun 11, 2025 that may be closed by this pull request

Add localization to client area (& server list) #1230

Open

	return trans('strings.backupstatus.'.str($this->value));
	return trans('strings.backup_status.'.str($this->value));

	return trans('strings.containerstatus.'.str($this->value));
	return trans('strings.container_status.'.str($this->value));

	->label(trans('strings.consolestatus.start'))
	->label(trans('strings.console_status.start'))

	->label(trans('strings.consolestatus.restart'))
	->label(trans('strings.console_status.restart'))

	->label(trans('strings.consolestatus.stop'))
	->label(trans('strings.console_status.stop'))

	'deletefileconfirm' => 'Delete file?',
	'delete_file_confirm' => 'Delete file?',

	'save&close' => 'Save & Close',
	'save_and_close' => 'Save & Close',

	return trans('strings.backupstatus.'.str($this->value));
	return trans('strings.backupstatus.' . $this->value);

	return trans('strings.containerstatus.'.str($this->value));
	return trans('strings.containerstatus.' . $this->value);

Uh oh!

Adding more translation strings for server panel (non-admin) #1418

Are you sure you want to change the base?

Adding more translation strings for server panel (non-admin) #1418

Uh oh!

Conversation

JamesMCL44 commented May 31, 2025

Uh oh!

github-actions bot commented May 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SirEndii commented May 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JamesMCL44 commented May 31, 2025

Uh oh!

SirEndii commented May 31, 2025

Uh oh!

JamesMCL44 commented May 31, 2025

Uh oh!

lancepioch left a comment

Choose a reason for hiding this comment

Uh oh!

lancepioch left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JamesMCL44 commented Jun 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rmartinoscar Jun 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented May 31, 2025 •

edited

Loading

SirEndii commented May 31, 2025 •

edited

Loading

JamesMCL44 commented Jun 7, 2025 •

edited

Loading

rmartinoscar Jun 8, 2025 •

edited

Loading