Allow to add translation prefix to custom subuser permissions#2265
Open
Allow to add translation prefix to custom subuser permissions#2265
Conversation
📝 WalkthroughWalkthroughChanges introduce dynamic, prefix-based translation key resolution for subuser permissions. The Changes
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@app/Models/Subuser.php`:
- Line 41: The new parameter $translationPrefix was inserted as the 3rd
positional argument in Subuser::registerCustomPermissions which shifts $icon and
$hidden and breaks existing callers; restore backward compatibility by moving
$translationPrefix to the end of the parameter list (e.g. keep
registerCustomPermissions(string $name, array $permissions,
null|string|BackedEnum $icon = null, ?bool $hidden = null, ?string
$translationPrefix = null)), update the method signature in
Subuser::registerCustomPermissions and any internal calls accordingly so
existing positional calls continue to work.
ℹ️ Review info
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
app/Filament/Server/Resources/Subusers/SubuserResource.phpapp/Models/Subuser.phplang/en/server/user.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2069
Supersedes #2185