Split htpy into multiple private modules#119
Merged
pelme merged 7 commits intopelme:mainfrom May 26, 2025
Merged
Conversation
We only import markupsafe in private modules, so it doesn't need to be aliased to avoid leaking the import.
It is still private as it is defined and exclusively used in private modules or inside functions.
These are still private as they are defined and exclusively used in private modules.
These are still private as they are defined and exclusively used in private modules.
These are still private as they are defined and exclusively used in private modules.
jodal
commented
May 25, 2025
pelme
pushed a commit
that referenced
this pull request
May 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an updated version of #109, as requested in #109 (comment)
The only changes to
htpy/*since #109 was created that I found are #112 and #117, which have both been applied to the first commit here.