feat: wrap _WithChildrenUnbound into function for better types #148
+21
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I've noticed this problem as well. Would be nice to get it fixed. Can we avoid duplicating the long docstring, e.g. by removing it from the class? Please remove the existing |
Owner
|
Good catch, LGTM with @jodal's suggestions. |
Contributor
Author
|
Thanks for the feedback! |
Contributor
|
@pelme Could we get this released? :-) |
Owner
|
sorry about the delay! we have such an amazing workflow for cutting new releases now so it is a breeze 😆 |
Owner
|
25.8.1 is out now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem at hand:
After PR:
