Classes space delimiter test #152
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StabbarN
force-pushed
the
classes-space-delimiter-test
branch
from
0617255 to
c62b751
Compare
Owner
|
I think it should be an error, just like |
pelme
reviewed
Aug 26, 2025
Owner
pelme
left a comment
pelme
left a comment
There was a problem hiding this comment.
I think we should be strict and raise errors instead.
StabbarN
added a commit
to StabbarN/htpy
that referenced
this pull request
Aug 27, 2025
See discussion in pelme#152.
StabbarN
added a commit
to StabbarN/htpy
that referenced
this pull request
Aug 27, 2025
See discussion in pelme#152.
Collaborator
Author
|
Got it. I created another PR. |
pelme
pushed a commit
that referenced
this pull request
Aug 28, 2025
* Minor fixes in streaming docs * Test to assert result with '.a b' * Raise error for whitespace in class shorthand See discussion in #152.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the expected result of
div(".a b")?As the example in https://htpy.dev/usage/#idclass-shorthand shows it should be
div(".a.b").Disallow
.a bwould be a breaking change so maybe we don't want that? In any case, should there be a test for it?