WIP: Add @htpy.compiler to inline/optimize static calls. #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A lot of htpy code is static calls that are hard coded in the source code like `p(id="foo")`. Every time it is invoked, a Python function call needs to happen to translate the Python keyword argument id to a HTML attribute string. With some ast rewrite tricks, we can find all calls to htpy functions that only have strings/dict literals/literal child nodes etc. We can then replace them with static strings. This commit replaces static calls with the resulting string and a CompiledElement. Doing that would effectively lead htpy code to be almost zero overhead, close to hand optimized string concatenation. (This is currently a very rough PoC version)
pelme
force-pushed
the
pelme-wunwsron
branch
from
0c7c91b to
5865584
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of htpy code is static calls that are hard coded in the source
code like
p(id="foo"). Every time it is invoked, a Python function callneeds to happen to translate the Python keyword argument id to a HTML attribute string.
With some ast rewrite tricks, we can find all calls to htpy functions
that only have strings/dict literals/literal child nodes etc. We can
then replace them with static strings.
This commit replaces static calls with the resulting string and a CompiledElement.
Doing that would effectively lead htpy code to be almost zero overhead,
close to hand optimized string concatenation.
(This is currently a very rough PoC version)