Fixed handling of non-generator iterators #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pelme
force-pushed
the
push-twmxtqtpotzu
branch
2 times, most recently
from
aec53b0 to
b391be8
Compare
Owner
Author
|
@astynax can you have a look and see if this solves your original problems? |
pelme
force-pushed
the
push-twmxtqtpotzu
branch
8 times, most recently
from
5c1e27d to
e91370e
Compare
pelme
changed the title
pelme
force-pushed
the
push-twmxtqtpotzu
branch
2 times, most recently
from
fb30eb6 to
142926d
Compare
pelme
force-pushed
the
push-twmxtqtpotzu
branch
from
142926d to
0e7372a
Compare
pelme
force-pushed
the
push-twmxtqtpotzu
branch
from
0e7372a to
f0d173d
Compare
Owner
Author
|
@astynax thanks for letting me know. will put out a new release soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously there were checks for generators specifically and not iterators in general. We also support one-off iterators that are not based on generators such as itertools.chain().
This regression was introduced in #56.
Based on #71.