Allow any node in context provider #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Very cool, thanks for bringing this up! I confused the consumer/provider side of things and agree that it seems unnecessary with the lambdas there. The lambdas are super annoying so getting rid of them here makes it much more straightforward. And this is totally backward compatible since callables are nodes too. This change looks good to me, I just need to think a little bit more about it before hitting merge! |
Contributor
Author
|
Cool, I just pushed some more changes to the documentation. |
Owner
|
Again, thanks for catching this. It removes an strange thing to consider when using contexts! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe I’m missing something here, but when I played around with contexts I noticed that you don’t need to pass a function to a context provider. Context consumers need to be function to delay evaluation until the context is available and this is taken care of by the decorator.