-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xsheet feature #1119
Draft
davidlamhauge
wants to merge
39
commits into
pencil2d:master
Choose a base branch
from
davidlamhauge:xsheet_dock
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Xsheet feature #1119
Changes from 31 commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
2dac3de
Xsheet shows up, can resize ok
davidlamhauge 981d948
Xsheet interacts with Timeline, not vice versa
davidlamhauge 3a7e2c1
Removed dead code. Use member variable in stead of parameter
davidlamhauge b1605da
WIP Xsheet must cope with add new layer, delete layer, etc
davidlamhauge 4879e99
Shortcut X. Modularized to subfunctions. Enhanced code
davidlamhauge d18c448
Color coded xsheet. Vector and Bitmap layers.
davidlamhauge 6da4c55
Loads papagayo files to xsheet
davidlamhauge 5215068
Optimizing colors in xsheet. Renaming stringlist
davidlamhauge 8772ef2
Erase xsheet possible.
davidlamhauge cd257f7
double click in xsheet gives a new keyframe in timeline
davidlamhauge 7a6f9e4
WIP FileDialog loads twice. Ignore commit
davidlamhauge 676101e
Almost 100% interactive. Scrub in Xsheet. Show/hide layer
davidlamhauge bf9baae
Erasing lipsync info, when new/open file
davidlamhauge f204a87
Minor rewrite og *.pgo file import
davidlamhauge 815e8b6
Load and Save lipsync column in xsheet
davidlamhauge c334012
Remove/Add Keyframes/Lipsync from xsheet.
davidlamhauge 4c7253b
Index error running on Win10 fixed (scrollToItem)
davidlamhauge 34553fe
Added addFrame button to xsheet. Cleaning up code
davidlamhauge f960b6e
Added csv Export. Small adjustments to come.
davidlamhauge 114c5c1
Rearranged xsheet icons. Fixed length bug
davidlamhauge 1f18cd1
Added suggestions for lipsync column. Clean up.
davidlamhauge b29cf1b
Ui enhanced. Less waste area.
davidlamhauge 3e3d76a
Improve xsheet frame selection
scribblemaniac 41ef981
Modify x-sheet spacing and text formatting
scribblemaniac ac88717
Merge pull request #1 from scribblemaniac/xsheet_interface_tweak
davidlamhauge 16f8a0f
Optimizing xsheet updates
davidlamhauge 6be66fe
replacing unstable function
davidlamhauge 3c2db50
Hide xsheet at startup, and small update fix
davidlamhauge 9513e28
Resolved merge conflicts
davidlamhauge 201d844
Adding support for identical layernames in xsheet
davidlamhauge b20d50b
Merge branch 'master' into xsheet_dock
davidlamhauge 58a8704
Not updating xsheet when it is hidden
davidlamhauge af54b36
Merged Master into xsheet_dock. Replaced obsolete functions
davidlamhauge 36d7058
Resolving merge conflicts with master branch
davidlamhauge 26ae355
Updating code
davidlamhauge 1df896a
Merged master into branch
davidlamhauge c404ea3
Merged master branch into xsheet_dock
davidlamhauge 21a296a
Renaming member variables to more logical names
davidlamhauge 9e4ccc3
same as last. Forgot changes in header file
davidlamhauge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the xsheet should be displayed by default. It will clutter the interface and cause confusion for new animators. Professional animators are the ones that will mainly benefit from this, and I think they should be more than capable of enabling it in from windows menu. Will see what they others have to say about this too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that the xsheet should be hidden by default. Pencil2D should keep its clean and easily accessible interface.
I also agree that the xsheet should be updated more efficient. I know there is a wish that the frames should be visible (in miniature) in the xsheet, so it will be corrected. That said, I think 60 fps or more i only seen in games, where it is common to have 50-100 fps, but that depends on cpu power. Hand drawn animation is max 24 or 25 fps in Europe and 30 fps in the States. Correct me if I'm wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm glad we agree. You would have to be crazy to do frame-by-frame animating in 60 fps, though maybe someone is importing a 60 fps video and rotoscoping on twos or something along those lines. It might also be useful for smoother camera motion since that does not require any extra work for the user. I was mainly using that as an example to demonstrate the issue more clearly. We've had many complaints about our playback speed so we should avoid compounding the issue with more contributing factors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I've solved the problems mentioned. Rewrites of xsheet is now limited to situations where it is necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@scribblemaniac I have made changes, so I use the layer index in stead of layer name as identifier. This means that identical layer names are supported now.