-
-
Notifications
You must be signed in to change notification settings - Fork 54
Changed kalman offset message to debug level #1877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is the core functionality of our daemon (i.e. determining what the time and frequency offsets are). I'm not sure what should be an info level log message, if this is not it? If you're not interested in that information, you could also increase the log level to warn or higher? |
I do think that the messages themselves might a little too spammy though: the formatting isn't great (way to many digits, most of them realistically completely useless information) and the number of messages might be too high especially when you have many sources (even more so with a low max poll interval) given that we get these messages most of the time when we receive a new packet from a source. |
I'm interested in this message at ntpd-rs/ntp-proto/src/algorithm/kalman/mod.rs Line 275 in b8e5b2c
|
Perhaps the better solution here is to make those jumps a warning. Thinking about this, that makes a certain amount of sense to me as it is something that may cause issues (not all software likes the system time jumping around) although it can be unavoidable. What do you think @rnijveld |
I have now been running Let's see the stats of how many messages in total SELECT host, count(message) FROM journald.logs WHERE ( timestamp >= $__fromTime AND timestamp <= $__toTime ) AND ( unit LIKE '%ntpd-rs%' ) GROUP by host ORDER by host I have a host that's produced almost ¾ of a million messages. Let's filter out any message with 'kalman' in it: SELECT host, count(message) FROM journald.logs WHERE ( timestamp >= $__fromTime AND timestamp <= $__toTime ) AND ( unit LIKE '%ntpd-rs%' ) AND ( NOT message LIKE '%kalman%' ) GROUP by host ORDER by host Well, that host that has suddenly dropped to just 294 messages. The ones with other higher counts of 10k+ are because I have some hosts on a network that can't get to the local IPv6 server thanks to #1880 so that logs is being filled with Here's a graph of the volume of all messages: And here's a graph of the same time period WITHOUT the Here the light blue, green and orange are the messages related IPv6 source mentioned above. Here's how quiet a host is with no IPv6 problems, or Basically, on boot-up; does the initial DNS resolution for the pool servers, logs the IPs and is then... essentially... silent. |
Sorry for the slow response, we've been discussing this a little internally, but haven't quite figured out a way forward yet. We do agree that the number of messages is a concern at the very least, but we also think that just moving this log message to a lower level isn't the way forward. I've summed up our current considerations in #1912, if you have any ideas we'd love to hear them in there, but I'll close this PR for now until we've found a good solution going forward. Thanks for all the effort you've put into this so far though! |
After deploying
ntpd-rs
on my systems, the system logs are peppered with:Which isn't useful to the average system admin, hence reduce this message to
debug
.