Skip to content

Changed kalman offset message to debug level #1877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jpds
Copy link
Contributor

@jpds jpds commented Apr 28, 2025

After deploying ntpd-rs on my systems, the system logs are peppered with:

ntp-daemon[2022]: 2025-04-28T22:16:44.902268Z  INFO ntp_proto::algorithm::kalman: Offset: -9.71569488420898+-5.958433943105912ms, frequency: -0.029784204729893793+-1.5403756385090928pp

Which isn't useful to the average system admin, hence reduce this message to debug.

@rnijveld
Copy link
Member

rnijveld commented May 1, 2025

This is the core functionality of our daemon (i.e. determining what the time and frequency offsets are). I'm not sure what should be an info level log message, if this is not it? If you're not interested in that information, you could also increase the log level to warn or higher?

@rnijveld
Copy link
Member

rnijveld commented May 1, 2025

I do think that the messages themselves might a little too spammy though: the formatting isn't great (way to many digits, most of them realistically completely useless information) and the number of messages might be too high especially when you have many sources (even more so with a low max poll interval) given that we get these messages most of the time when we receive a new packet from a source.

@jpds
Copy link
Contributor Author

jpds commented May 1, 2025

I'm interested in this message at info:

info!("Jumped offset by {}ms", change * 1e3);
- but not these ones.

@davidv1992
Copy link
Member

Perhaps the better solution here is to make those jumps a warning. Thinking about this, that makes a certain amount of sense to me as it is something that may cause issues (not all software likes the system time jumping around) although it can be unavoidable. What do you think @rnijveld

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants