Skip to content

Use canonical addresses for the IP filter#2359

Open
rnijveld wants to merge 1 commit into
mainfrom
filter-use-canonical-addresses
Open

Use canonical addresses for the IP filter#2359
rnijveld wants to merge 1 commit into
mainfrom
filter-use-canonical-addresses

Conversation

@rnijveld

@rnijveld rnijveld commented Jul 19, 2026

Copy link
Copy Markdown
Member

Alternative for #2354 and #2353, fixes #2131

This implementation canonicalizes both the filter IP addresses as well as the IP addresses that are being tested against.

Thanks to @ibondarenko1 and @upmcplanetracker for the inspiration.

@rnijveld
rnijveld requested a review from davidv1992 July 19, 2026 08:39
@rnijveld rnijveld self-assigned this Jul 19, 2026
@codecov

codecov Bot commented Jul 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.23810% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.17%. Comparing base (2f21eeb) to head (077758e).

Files with missing lines Patch % Lines
ntp-proto/src/server.rs 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2359      +/-   ##
==========================================
+ Coverage   81.08%   81.17%   +0.08%     
==========================================
  Files         114      114              
  Lines       23726    23747      +21     
==========================================
+ Hits        19239    19276      +37     
+ Misses       4487     4471      -16     
Flag Coverage Δ
fuzz-cookie_parsing_sound 0.39% <0.00%> (-0.23%) ⬇️
fuzz-duration_from_float 0.25% <0.00%> (-0.01%) ⬇️
fuzz-encrypted_client_parsing 6.86% <0.00%> (+0.24%) ⬆️
fuzz-encrypted_server_parsing 10.11% <0.00%> (+0.38%) ⬆️
fuzz-handle 11.53% <46.66%> (-1.49%) ⬇️
fuzz-ipfilter 2.55% <52.63%> (+0.05%) ⬆️
fuzz-key_exchange_request_parsing 3.79% <0.00%> (-1.15%) ⬇️
fuzz-key_exchange_response_parsing 3.64% <0.00%> (-0.01%) ⬇️
fuzz-packet_keyset 5.61% <0.00%> (+1.67%) ⬆️
fuzz-packet_parsing_sound 6.06% <0.00%> (-0.01%) ⬇️
fuzz-ptp_message_parsing 51.56% <ø> (-7.48%) ⬇️
fuzz-record_encode_decode 4.42% <0.00%> (+0.02%) ⬆️
test-aarch64-apple-darwin 81.32% <89.47%> (+<0.01%) ⬆️
test-x86_64-unknown-linux-gnu 80.11% <89.47%> (+<0.01%) ⬆️
test-x86_64-unknown-linux-musl 79.99% <89.47%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rnijveld
rnijveld force-pushed the filter-use-canonical-addresses branch 2 times, most recently from 837dd15 to 3bb54c8 Compare July 19, 2026 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IPv4 addresses in allowlist don't work when listening on IPv6

2 participants