Use canonical addresses for the IP filter#2359
Open
rnijveld wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2359 +/- ##
==========================================
+ Coverage 81.08% 81.17% +0.08%
==========================================
Files 114 114
Lines 23726 23747 +21
==========================================
+ Hits 19239 19276 +37
+ Misses 4487 4471 -16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
rnijveld
force-pushed
the
filter-use-canonical-addresses
branch
2 times, most recently
from
July 19, 2026 08:47
837dd15 to
3bb54c8
Compare
rnijveld
force-pushed
the
filter-use-canonical-addresses
branch
from
July 19, 2026 09:02
3bb54c8 to
077758e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative for #2354 and #2353, fixes #2131
This implementation canonicalizes both the filter IP addresses as well as the IP addresses that are being tested against.
Thanks to @ibondarenko1 and @upmcplanetracker for the inspiration.