Introduce ruff and codespell, rework Github-Workflows, move packaging to pyproject.toml#59
Open
SmithChart wants to merge 14 commits intopengutronix:masterfrom
Open
Introduce ruff and codespell, rework Github-Workflows, move packaging to pyproject.toml#59SmithChart wants to merge 14 commits intopengutronix:masterfrom
SmithChart wants to merge 14 commits intopengutronix:masterfrom
Conversation
The Github-Workflows will be recreated in a later commit once packaging and other refactoring has been completed. Signed-off-by: Chris Fiege <cfi@pengutronix.de>
Signed-off-by: Chris Fiege <cfi@pengutronix.de>
Signed-off-by: Chris Fiege <cfi@pengutronix.de>
Signed-off-by: Chris Fiege <cfi@pengutronix.de>
Signed-off-by: Chris Fiege <cfi@pengutronix.de>
Contributor
|
Suppose this resolves #58 |
Member
Author
Yes, I assume so. |
hnez
requested changes
Mar 3, 2026
tox.ini
Outdated
Member
There was a problem hiding this comment.
Maybe also remove the mentions of tox in the Makefile in this commit?
Member
Author
There was a problem hiding this comment.
This got detached from a code change or commit. Do you know where this belongs?
These are fixes for ruff check findings that could not be applied automatically. These changes should be a no-op. Signed-off-by: Chris Fiege <cfi@pengutronix.de>
Signed-off-by: Chris Fiege <cfi@pengutronix.de>
Signed-off-by: Chris Fiege <cfi@pengutronix.de>
The `pytest.py`-file inside the Flamingo-package only contains code relevant for testing - and also fixtures used by the tests. Let's move it into the `tests/`-directory and call it `conftest.py` as it should be. Signed-off-by: Chris Fiege <cfi@pengutronix.de>
This commit reintroduces Github workflows in more modern way. Releases to pypi are now done using the "trusted publisher"-mechanism. Signed-off-by: Chris Fiege <cfi@pengutronix.de> Co-authored-by: Leonard Göhrs <leonard@goehrs.eu>
BS4 suggests to use these new, different names. So let's comply and get rid of the deprecation warnings during testing. Signed-off-by: Chris Fiege <cfi@pengutronix.de>
Signed-off-by: Chris Fiege <cfi@pengutronix.de>
This commit moves to pyproject.toml for packaging of flamingo. This commit intends to (mostly, see exception below) to only transfer settings from the setup.py-world into the pyproject.toml without any further functional changes. The exception here is that the CLI-scripts get refactored from the standalone directory `bin/` into the python package `flamingo/bin/`. Signed-off-by: Chris Fiege <cfi@pengutronix.de>
At this point row has already been initialized as list and is only changed using list.append(). This means we can safely drop the additional list() here. Signed-off-by: Chris Fiege <cfi@pengutronix.de>
SmithChart
force-pushed
the
github-workflow
branch
from
0f0b00a to
827a39f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a rather heavy PR that tries to add a lot of current best practices to the flamingo code-base and repo. It does:
setup.pytopyproject.toml